datadog-agent
datadog-agent copied to clipboard
play snapshot on new policies
What does this PR do?
This PR aims to play the snapshot when new policies are loaded locally or through remote configuration
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
- Start the agent
- Create a new policy locally by adding a new policy file in your policies directory (runtime_security_config.policies.watch_dir needs to be set to true) or push a new remote policy
- The execution of playSnapshot should appear in system-probe's logs
Regression Detector
Regression Detector Results
Run ID: 0953b71b-4e33-452a-ad9c-3e5052411b6f Metrics dashboard Target profiles
Baseline: f78e4b2f9772aeadf9fa3197b774dfe6e3d8a345 Comparison: 0aba94c26070cb934a6dab18277b1c207a5c22f1
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +0.90 | [+0.07, +1.73] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.27 | [-0.49, +1.03] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | +0.18 | [-2.65, +3.00] | 1 | Logs |
| ➖ | idle | memory utilization | +0.12 | [+0.08, +0.17] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.11 | [-0.00, +0.23] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | +0.04 | [-2.68, +2.77] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.65 | [-0.70, -0.60] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ❌ | idle | memory_usage | 8/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=44507331 --os-family=ubuntu
Note: This applies to commit 0aba94c2
/merge
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main is 25m.
Use /merge -c to cancel this operation!