What does this PR do?

This PR sets up follow-up work that will turn the Catalog into a full fledged Component. Instead of having multiple ways to select catalogs (build tags / agent flavor / etc) we will use separate implementations, which each agent binary will be able to select at its entry point. This will enable full separation of dependencies for different collector catalogs.

This PR is best reviewed one commit at a time.

Motivation

RFC on component's new usage of fx, including how to define components with multiple implementations, as a way to control dependencies: https://docs.google.com/document/d/1sPXUviG-RvMCUvqdwfUYbTOTV05Z_y9MuwlYcyOdG0I/edit#heading=h.o5gstqo08gu5

Additional Notes

As a next step, the catalogs will move from comp/core/workloadmeta/collectors/catalog-{*} to comp/core/wmcatalog/impl-{*} as wmcatalog becomes a true component. As for the collectors, it seems like the best option would be to move them from comp/core/workloadmeta/collectors/internal to comp/core/wmcatalog/internal/collectors in order to work with both the multi-impl paradigm and the semantics of importing internal packages.

Possible Drawbacks / Trade-offs

It may be more difficult to pass arbitrary data to the Collector's constructor, as the remoteworkloadmeta collector shows. However, it does not seem to be the case that Collectors need to do this very often; most simply require the config.

Describe how to test/QA your changes

No functional change, behavior should remain the same as before this refactoring.

Aug 20 '24 20:08 dustmop

Go Package Import Differences

Baseline: 3b1e55e56538154e60bd0bde5847faba8c4e6baf Comparison: 9e07a83b5f2d71112b500d3938a41c2d4faa5e47

binary	os	arch	change
agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
agent	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
agent	darwin	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
agent	darwin	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
iot-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
iot-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
heroku-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
cluster-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
cluster-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
cluster-agent-cloudfoundry	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
cluster-agent-cloudfoundry	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
dogstatsd	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
dogstatsd	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
process-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
process-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
process-agent	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
process-agent	darwin	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
process-agent	darwin	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
heroku-process-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
security-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
security-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
serverless	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
serverless	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
system-probe	linux	amd64	+5, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def +github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/util +github.com/DataDog/datadog-agent/pkg/util/ecs/common +github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v3or4 +github.com/DataDog/datadog-agent/pkg/util/ecs/telemetry
system-probe	linux	arm64	+5, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def +github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/util +github.com/DataDog/datadog-agent/pkg/util/ecs/common +github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v3or4 +github.com/DataDog/datadog-agent/pkg/util/ecs/telemetry
system-probe	windows	amd64	+5, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def +github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/util +github.com/DataDog/datadog-agent/pkg/util/ecs/common +github.com/DataDog/datadog-agent/pkg/util/ecs/metadata/v3or4 +github.com/DataDog/datadog-agent/pkg/util/ecs/telemetry
trace-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
trace-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
trace-agent	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
trace-agent	darwin	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
trace-agent	darwin	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def
heroku-trace-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/wmcatalog/def

Aug 20 '24 20:08 cit-pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=43206915 --os-family=ubuntu

Note: This applies to commit 9e07a83b

Aug 20 '24 21:08 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 8881ee37-8a99-45cc-8688-0af990321d69 Metrics dashboard Target profiles

Baseline: 3b1e55e56538154e60bd0bde5847faba8c4e6baf Comparison: 9e07a83b5f2d71112b500d3938a41c2d4faa5e47

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.07	[+1.11, +3.04]	Logs
➖	pycheck_lots_of_tags	% cpu utilization	+1.94	[-0.53, +4.40]	Logs
➖	file_tree	memory utilization	+0.15	[+0.08, +0.21]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	idle	memory utilization	-0.05	[-0.08, -0.02]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.59	[-1.40, +0.22]	Logs
➖	basic_py_check	% cpu utilization	-2.12	[-4.67, +0.43]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-3.73	[-16.27, +8.81]	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Aug 20 '24 22:08 pr-commenter[bot]

I have suggestion to make to refactor a bit how collectors initialization works.

I see we do not use the error returned from the constructors. At the same time the Start function from the Collector usually check if the current environments support such collector:

if !pkgconfig.IsFeaturePresent(pkgconfig.Docker) {
  return errorspkg.NewDisabled(componentName, "Agent is not running on Docker")
}

I say we could move the checking of the feature to the NewCollector collector function, then we are building the collectors catalog, we check the error returned from the newCollector function and if is nil we add the catalog.

// NewCollector returns a new docker collector
func NewCollector(cfg config.Component) (wmcatalog.Collector, error) {
	if !pkgconfig.IsFeaturePresent(pkgconfig.Docker) {
		return nil, errorspkg.NewDisabled(componentName, "Agent is not running on Docker")
	}
	
	return &collector{
		id:      collectorID,
		config:  cfg,
		catalog: workloadmeta.NodeAgent | workloadmeta.ProcessAgent,
	}, nil
}

Then in the util build catalog would be:

// BuildCatalog builds a list of Collectors by invoking their constructors
func BuildCatalog(cfg config.Component, constructors ...func(config.Component) (wmcatalog.Collector, error)) []wmcatalog.Collector {
	results := []wmcatalog.Collector{}
	for _, ctor := range constructors {
		item, err := ctor(cfg)
		if err != nil {
			results = append(results, item)
		}
	}
	return results
}

Positive outcomes, is that we instantiate less objects 🎉

Aug 21 '24 08:08 GustavoCaso

Are we planning on removing the remotewmonly build flag on the next steps?

Aug 21 '24 08:08 GustavoCaso

Are we planning on removing the remotewmonly build flag on the next steps?

Yes, the wmcatalog component will have its own implementation that takes over what the remotewmonly build flag is doing. I checked with @paulcacheux a while back and heard that doing so is okay.

Aug 21 '24 21:08 dustmop

I see we do not use the error returned from the constructors. At the same time the Start function from the Collector usually check if the current environments support such collector:

Ah, that's a good point that the error returned by the constructors isn't being used. It had semantics that fx cares about, but this is removing fx from the collectors, which is introducing a bug. I'll work on fixing that.

Aug 21 '24 21:08 dustmop

I see we do not use the error returned from the constructors. At the same time the Start function from the Collector usually check if the current environments support such collector:

Ah, that's a good point that the error returned by the constructors isn't being used. It had semantics that fx cares about, but this is removing fx from the collectors, which is introducing a bug. I'll work on fixing that.

Looking into it, the error should be removed from the collector constructors, it can't be used and we're already checking for whether the collector is non-nil.

Aug 22 '24 00:08 dustmop

:warning::rotating_light: Warning, this pull request increases the binary size of serverless extension by 0 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

Debug info

These dependencies were added to the serverless extension by this pull request:

View dependency graphs for each added dependency in the artifacts section of the github action.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

Aug 28 '24 18:08 github-actions[bot]

:warning::rotating_light: Warning, this pull request increases the binary size of serverless extension by 0 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

Debug info

These dependencies were added to the serverless extension by this pull request:

View dependency graphs for each added dependency in the artifacts section of the github action.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

Aug 28 '24 19:08 github-actions[bot]

:warning::rotating_light: Warning, this pull request increases the binary size of serverless extension by 0 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

Debug info

These dependencies were added to the serverless extension by this pull request:

View dependency graphs for each added dependency in the artifacts section of the github action.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

Aug 28 '24 19:08 github-actions[bot]

:warning::rotating_light: Warning, this pull request increases the binary size of serverless extension by 0 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

Debug info

These dependencies were added to the serverless extension by this pull request:

View dependency graphs for each added dependency in the artifacts section of the github action.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

Aug 28 '24 20:08 github-actions[bot]

:warning::rotating_light: Warning, this pull request increases the binary size of serverless extension by 0 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

Debug info

These dependencies were added to the serverless extension by this pull request:

View dependency graphs for each added dependency in the artifacts section of the github action.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

Aug 29 '24 20:08 github-actions[bot]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 42a46ffdd2caef01e17169d0e6b220e4a0115c86 and 83d6809c92bd958c9e8638fe40a6cf607b177c64.

tl;dr

Use these benchmarks as an insight tool during development.

Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.
The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            84.30µ ± 5%   81.81µ ± 3%  -2.95% (p=0.019 n=10)
api-gateway-kong-appsec.json                       69.21µ ± 3%   65.25µ ± 1%  -5.73% (p=0.002 n=10)
api-gateway-kong.json                              67.63µ ± 2%   63.55µ ± 1%  -6.03% (p=0.000 n=10)
api-gateway-non-proxy-async.json                   108.2µ ± 2%   101.1µ ± 2%  -6.54% (p=0.000 n=10)
api-gateway-non-proxy.json                         108.5µ ± 3%   102.2µ ± 1%  -5.79% (p=0.000 n=10)
api-gateway-websocket-connect.json                 70.55µ ± 1%   67.48µ ± 1%  -4.35% (p=0.000 n=10)
api-gateway-websocket-default.json                 62.84µ ± 1%   61.43µ ± 1%  -2.24% (p=0.000 n=10)
api-gateway-websocket-disconnect.json              64.39µ ± 3%   61.49µ ± 1%  -4.50% (p=0.000 n=10)
api-gateway.json                                   116.5µ ± 2%   112.9µ ± 1%  -3.11% (p=0.000 n=10)
application-load-balancer.json                     63.94µ ± 1%   61.60µ ± 1%  -3.66% (p=0.000 n=10)
cloudfront.json                                    48.10µ ± 8%   46.61µ ± 2%  -3.10% (p=0.000 n=10)
cloudwatch-events.json                             38.53µ ± 2%   37.45µ ± 2%  -2.80% (p=0.002 n=10)
cloudwatch-logs.json                               66.64µ ± 3%   64.31µ ± 1%  -3.50% (p=0.000 n=10)
custom.json                                        31.03µ ± 2%   30.63µ ± 2%       ~ (p=0.123 n=10)
dynamodb.json                                      96.27µ ± 2%   92.25µ ± 1%  -4.18% (p=0.000 n=10)
empty.json                                         30.11µ ± 1%   29.10µ ± 1%  -3.36% (p=0.000 n=10)
eventbridge-custom.json                            43.34µ ± 2%   41.80µ ± 3%  -3.55% (p=0.004 n=10)
http-api.json                                      74.20µ ± 2%   71.81µ ± 1%  -3.23% (p=0.000 n=10)
kinesis-batch.json                                 72.08µ ± 1%   70.33µ ± 2%  -2.43% (p=0.000 n=10)
kinesis.json                                       54.96µ ± 2%   53.90µ ± 1%  -1.93% (p=0.009 n=10)
s3.json                                            61.20µ ± 2%   59.33µ ± 2%  -3.06% (p=0.003 n=10)
sns-batch.json                                     93.23µ ± 4%   89.59µ ± 1%  -3.90% (p=0.000 n=10)
sns.json                                           67.60µ ± 1%   64.35µ ± 1%  -4.81% (p=0.000 n=10)
snssqs.json                                        116.2µ ± 2%   107.6µ ± 1%  -7.42% (p=0.000 n=10)
snssqs_no_dd_context.json                         105.20µ ± 1%   96.69µ ± 1%  -8.09% (p=0.000 n=10)
sqs-aws-header.json                                58.83µ ± 2%   54.83µ ± 1%  -6.80% (p=0.000 n=10)
sqs-batch.json                                     99.81µ ± 2%   92.75µ ± 2%  -7.07% (p=0.000 n=10)
sqs.json                                           72.22µ ± 1%   68.28µ ± 1%  -5.45% (p=0.000 n=10)
sqs_no_dd_context.json                             63.80µ ± 1%   62.25µ ± 2%  -2.42% (p=0.000 n=10)
geomean                                            68.58µ        65.65µ       -4.27%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.32Ki ± 0%   37.32Ki ± 0%       ~ (p=0.926 n=10)
api-gateway-kong-appsec.json                      26.93Ki ± 0%   26.92Ki ± 0%       ~ (p=0.272 n=10)
api-gateway-kong.json                             24.42Ki ± 0%   24.41Ki ± 0%       ~ (p=0.171 n=10)
api-gateway-non-proxy-async.json                  48.10Ki ± 0%   48.08Ki ± 0%       ~ (p=0.288 n=10)
api-gateway-non-proxy.json                        47.32Ki ± 0%   47.30Ki ± 0%  -0.03% (p=0.045 n=10)
api-gateway-websocket-connect.json                25.49Ki ± 0%   25.49Ki ± 0%       ~ (p=0.468 n=10)
api-gateway-websocket-default.json                21.40Ki ± 0%   21.39Ki ± 0%       ~ (p=0.322 n=10)
api-gateway-websocket-disconnect.json             21.18Ki ± 0%   21.18Ki ± 0%       ~ (p=0.099 n=10)
api-gateway.json                                  49.55Ki ± 0%   49.56Ki ± 0%       ~ (p=0.926 n=10)
application-load-balancer.json                    23.27Ki ± 0%   23.26Ki ± 0%       ~ (p=0.210 n=10)
cloudfront.json                                   17.66Ki ± 0%   17.66Ki ± 0%       ~ (p=0.383 n=10)
cloudwatch-events.json                            11.71Ki ± 0%   11.72Ki ± 0%       ~ (p=0.670 n=10)
cloudwatch-logs.json                              53.38Ki ± 0%   53.36Ki ± 0%       ~ (p=0.239 n=10)
custom.json                                       9.728Ki ± 0%   9.734Ki ± 0%       ~ (p=0.209 n=10)
dynamodb.json                                     40.81Ki ± 0%   40.79Ki ± 0%  -0.05% (p=0.027 n=10)
empty.json                                        9.284Ki ± 0%   9.286Ki ± 0%       ~ (p=0.517 n=10)
eventbridge-custom.json                           13.44Ki ± 0%   13.43Ki ± 0%       ~ (p=0.425 n=10)
http-api.json                                     23.80Ki ± 0%   23.77Ki ± 0%  -0.14% (p=0.037 n=10)
kinesis-batch.json                                27.03Ki ± 0%   27.04Ki ± 0%       ~ (p=0.541 n=10)
kinesis.json                                      17.82Ki ± 0%   17.83Ki ± 0%       ~ (p=0.184 n=10)
s3.json                                           20.37Ki ± 0%   20.37Ki ± 0%       ~ (p=0.698 n=10)
sns-batch.json                                    38.69Ki ± 0%   38.66Ki ± 0%       ~ (p=0.079 n=10)
sns.json                                          23.93Ki ± 1%   23.96Ki ± 0%       ~ (p=0.271 n=10)
snssqs.json                                       50.59Ki ± 0%   50.56Ki ± 0%       ~ (p=0.579 n=10)
snssqs_no_dd_context.json                         44.89Ki ± 0%   44.82Ki ± 0%       ~ (p=0.138 n=10)
sqs-aws-header.json                               18.85Ki ± 1%   18.80Ki ± 0%       ~ (p=0.239 n=10)
sqs-batch.json                                    41.64Ki ± 0%   41.58Ki ± 0%       ~ (p=0.190 n=10)
sqs.json                                          25.55Ki ± 0%   25.48Ki ± 1%       ~ (p=0.075 n=10)
sqs_no_dd_context.json                            20.71Ki ± 0%   20.69Ki ± 1%       ~ (p=0.481 n=10)
geomean                                           25.76Ki        25.75Ki       -0.04%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             629.5 ± 0%   629.5 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    725.5 ± 0%   725.0 ± 0%       ~ (p=0.650 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=0.526 n=10)
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-disconnect.json               370.0 ± 0%   369.5 ± 0%  -0.14% (p=0.033 n=10)
api-gateway.json                                    791.0 ± 0%   790.5 ± 0%       ~ (p=1.000 n=10)
application-load-balancer.json                      353.0 ± 0%   353.0 ± 0%       ~ (p=1.000 n=10)
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=0.582 n=10)
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=1.000 n=10)
cloudwatch-logs.json                                216.0 ± 0%   215.0 ± 0%       ~ (p=0.370 n=10)
custom.json                                         168.0 ± 0%   168.0 ± 0%       ~ (p=1.000 n=10) ¹
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=1.000 n=10)
empty.json                                          159.0 ± 1%   159.5 ± 0%       ~ (p=1.000 n=10)
eventbridge-custom.json                             254.0 ± 0%   254.0 ± 0%       ~ (p=0.420 n=10)
http-api.json                                       433.0 ± 0%   432.0 ± 0%       ~ (p=0.120 n=10)
kinesis-batch.json                                  390.0 ± 0%   390.5 ± 0%       ~ (p=0.119 n=10)
kinesis.json                                        285.0 ± 0%   285.0 ± 0%       ~ (p=0.837 n=10)
s3.json                                             358.0 ± 0%   358.0 ± 0%       ~ (p=1.000 n=10)
sns-batch.json                                      455.0 ± 0%   455.0 ± 0%       ~ (p=0.296 n=10)
sns.json                                            322.0 ± 1%   323.0 ± 0%       ~ (p=0.465 n=10)
snssqs.json                                         437.5 ± 1%   437.0 ± 0%       ~ (p=0.567 n=10)
snssqs_no_dd_context.json                           400.0 ± 1%   399.0 ± 0%       ~ (p=0.179 n=10)
sqs-aws-header.json                                 274.5 ± 1%   274.0 ± 1%       ~ (p=0.123 n=10)
sqs-batch.json                                      503.5 ± 0%   502.5 ± 0%       ~ (p=0.238 n=10)
sqs.json                                            351.0 ± 0%   349.5 ± 0%  -0.43% (p=0.019 n=10)
sqs_no_dd_context.json                              324.5 ± 0%   324.0 ± 1%       ~ (p=0.463 n=10)
geomean                                             376.4        376.2       -0.05%
¹ all samples are equal

Aug 29 '24 21:08 github-actions[bot]

datadog-agent
datadog-agent copied to clipboard

[ASCII-2221] GetCatalog is fx entry point, remove fx from Collectors

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Go Package Import Differences

Test changes on VM

Regression Detector

Regression Detector Results

No significant changes in experiment optimization goals

Fine details of change detection per experiment

Bounds Checks

Explanation

Serverless Benchmark Results

datadog-agent datadog-agent copied to clipboard

[ASCII-2221] GetCatalog is fx entry point, remove fx from Collectors

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Go Package Import Differences

Test changes on VM

Regression Detector

Regression Detector Results

No significant changes in experiment optimization goals

Fine details of change detection per experiment

Bounds Checks

Explanation

Serverless Benchmark Results

datadog-agent
datadog-agent copied to clipboard