Fix log line when failing to start services

[JakeYankovich]

What does this PR do?

CA StartDDServices attempts to start the DD services, and when it fails it should log Failed to start services instead of Failed to stop services

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[agent-platform-auto-pr[bot]]

[Fast Unit Tests Report]

On pipeline 43105408 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 7f14b19a-a121-4658-83f0-cd9d8658b1b3 Metrics dashboard Target profiles

Baseline: c81921c0283d86d0ff6030cf95196f77a1c6ee7b Comparison: 30f40a2ffc8274fde9f250761dda9728df2f9346

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	tcp_syslog_to_blackhole	ingress throughput	+2.34	[-10.58, +15.26]	Logs
➖	otel_to_otel_logs	ingress throughput	+1.35	[+0.53, +2.16]	Logs
➖	idle	memory utilization	+0.27	[+0.23, +0.30]	Logs
➖	file_tree	memory utilization	+0.16	[+0.10, +0.22]	Logs
➖	basic_py_check	% cpu utilization	+0.03	[-2.54, +2.60]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.05, +0.05]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.21	[-1.17, +0.74]	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-0.33	[-2.78, +2.12]	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[clarkb7]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!