datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-2139] Use telemetry component for core telemetry check

Open GustavoCaso opened this issue 1 year ago • 2 comments

What does this PR do?

Remove the usage of global function to access the telemetry component inside the core telemetry check.

Motivation

reduce usage of functions that do not follow the component framework patterns

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

~~Unit test have being updated~~ Unit test are present to validate the changes did not broke anything

GustavoCaso avatar Aug 08 '24 13:08 GustavoCaso

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=44545876 --os-family=ubuntu

Note: This applies to commit cd08501f

pr-commenter[bot] avatar Aug 08 '24 13:08 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: f02a727f-b37a-40c4-aebf-f27c2de9897d Metrics dashboard Target profiles

Baseline: 023ef5945eaed5aea081f20a7788a68c0107f816 Comparison: cd08501fbc1de0ada35b160cf43c00052db3b79c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +2.44 [-0.37, +5.25] 1 Logs
file_tree memory utilization +1.06 [+0.95, +1.17] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.69 [-0.07, +1.45] 1 Logs
idle memory utilization +0.47 [+0.43, +0.51] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.27 [+0.22, +0.32] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
otel_to_otel_logs ingress throughput -0.73 [-1.56, +0.09] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.13 [-3.81, +1.56] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 9/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Aug 08 '24 14:08 pr-commenter[bot]

/merge

GustavoCaso avatar Sep 18 '24 14:09 GustavoCaso

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Sep 18 '24 14:09 dd-devflow[bot]