Extend the `protected-branch` hook to pre-push

[FlorentClarret]

What does this PR do?

Extend the protected-branch hook to pre-push

Motivation

I almost pushed to main but managed to ctrl-c in time. This hook will prevent us from doing it in the future. If we really need to push, we can still add --no-verify to break the glass

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[agent-platform-auto-pr[bot]]

[Fast Unit Tests Report]

On pipeline 38346771 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 44819c4b-753b-413a-9048-8e15a9884e8d Metrics dashboard Target profiles

Baseline: e988f5f9555c6a35954c2579b1208c2f360bba63 Comparison: e97250d6b1bf0a47cd737fccec3b621f38f9fd3a

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	basic_py_check	% cpu utilization	+0.59	[-2.04, +3.22]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	+0.34	[-4.55, +5.24]	Logs
➖	file_tree	memory utilization	+0.03	[-0.01, +0.08]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.09	[-0.98, +0.81]	Logs
➖	idle	memory utilization	-0.49	[-0.52, -0.45]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.50	[-1.30, +0.31]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-2.75	[-15.25, +9.74]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[FlorentClarret]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 26m.

Use /merge -c to cancel this operation!