datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Guy.arbitman/fix https test

Open guyarb opened this issue 1 year ago • 1 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

guyarb avatar Jul 04 '24 06:07 guyarb

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38377956 --os-family=ubuntu

Note: This applies to commit be063854

pr-commenter[bot] avatar Jul 04 '24 07:07 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: ed99fc63-69de-45f6-80a1-1b8266f635c5 Metrics dashboard Target profiles

Baseline: e82159344869f51cc1ec23612222cacc1e5e841b Comparison: be063854d402a8d5ec4040b7494823ea612b2de8

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
file_tree memory utilization +2.77 [+2.64, +2.89] Logs
otel_to_otel_logs ingress throughput +0.44 [-0.37, +1.26] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.03 [-0.86, +0.92] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
basic_py_check % cpu utilization -0.12 [-2.76, +2.52] Logs
idle memory utilization -0.49 [-0.53, -0.44] Logs
pycheck_1000_100byte_tags % cpu utilization -0.49 [-5.30, +4.31] Logs
tcp_syslog_to_blackhole ingress throughput -1.68 [-14.28, +10.91] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jul 04 '24 07:07 pr-commenter[bot]