datadog-agent
datadog-agent copied to clipboard
Fix the `qa_agent_ot` GitLab job
What does this PR do?
Fix the qa_agent_ot GitLab job.
Motivation
The tag of the docker image consumed by qa_agent_ot here: https://github.com/DataDog/datadog-agent/blob/04c5db04f035dbe33040df6e8a005dcfc03945e8/.gitlab/dev_container_deploy/docker_linux.yml#L298
needs to match the tag of the docker images produced by the dependencies declared here: https://github.com/DataDog/datadog-agent/blob/04c5db04f035dbe33040df6e8a005dcfc03945e8/.gitlab/dev_container_deploy/docker_linux.yml#L294-L295
and when we look at those jobs here: https://github.com/DataDog/datadog-agent/blob/04c5db04f035dbe33040df6e8a005dcfc03945e8/.gitlab/container_build/docker_linux.yml#L197
and there: https://github.com/DataDog/datadog-agent/blob/04c5db04f035dbe33040df6e8a005dcfc03945e8/.gitlab/container_build/docker_linux.yml#L211
we see that the -beta part of the suffix seems to be missing.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
[Fast Unit Tests Report]
On pipeline 38323988 (CI Visibility). The following jobs did not run any unit tests:
Jobs:
- tests_deb-arm64-py3
- tests_deb-x64-py3
- tests_flavor_dogstatsd_deb-x64
- tests_flavor_heroku_deb-x64
- tests_flavor_iot_deb-x64
- tests_rpm-arm64-py3
- tests_rpm-x64-py3
- tests_windows-x64
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help
qa_agent_ot job passed: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/561840882
Regression Detector
Regression Detector Results
Run ID: 91ccdebb-c162-4370-b407-3d85a1bf9588 Metrics dashboard Target profiles
Baseline: 04c5db04f035dbe33040df6e8a005dcfc03945e8 Comparison: aeb2d735203a74bd12b7edde83b25482d73d5284
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +2.84 | [-10.25, +15.93] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.43 | [+0.54, +2.32] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.63 | [-0.19, +1.44] | Logs |
| ➖ | idle | memory utilization | +0.09 | [+0.05, +0.13] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.03 | [-2.48, +2.41] | Logs |
| ➖ | file_tree | memory utilization | -1.31 | [-1.39, -1.23] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -4.91 | [-9.37, -0.46] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Superseded by #27315.