[AGENT-11817] Fix logs config prefix in diagnose command

[pgimalac]

What does this PR do?

Fix the logs_config prefix in diagnose package, which was missing a trailing ..

Motivation

It was resulting in warnings about unknown configs, and likely incorrect behavior of the diagnose command around logs endpoints.

Additional Notes

2024-07-03 17:42:46 CEST | CORE | WARN | (pkg/config/model/viper.go:192 in checkKnownKey) | config key logs_configlogs_no_ssl is unknown
2024-07-03 17:42:46 CEST | CORE | WARN | (pkg/config/model/viper.go:192 in checkKnownKey) | config key logs_configuse_compression is unknown
2024-07-03 17:42:46 CEST | CORE | WARN | (pkg/config/model/viper.go:192 in checkKnownKey) | config key logs_configcompression_level is unknown
2024-07-03 17:42:46 CEST | CORE | WARN | (pkg/config/model/viper.go:192 in checkKnownKey) | config key logs_configconnection_reset_interval is unknown
2024-07-03 17:42:46 CEST | CORE | WARN | (pkg/config/model/viper.go:192 in checkKnownKey) | config key logs_configsender_backoff_base is unknown

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Tested manually that the warnings were removed.

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 39a92eb9-53e3-4409-b6f7-94305d7ebf26 Metrics dashboard Target profiles

Baseline: 7e40dff2c54b00187e9cffa73e62006701447968 Comparison: 711ff02ca9fd2a621798dedcd43c754a3311c245

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	tcp_syslog_to_blackhole	ingress throughput	+1.84	[-11.06, +14.74]	Logs
➖	basic_py_check	% cpu utilization	+0.89	[-1.79, +3.58]	Logs
➖	idle	memory utilization	+0.81	[+0.77, +0.85]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.52	[-0.36, +1.41]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.33	[-1.14, +0.48]	Logs
➖	file_tree	memory utilization	-0.36	[-0.45, -0.26]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	-1.99	[-6.68, +2.71]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38289287 --os-family=ubuntu

Note: This applies to commit 711ff02c

[pgimalac]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!