Paulcacheux/go libddwaf v3 compressed

[paulcacheux]

trafficstars

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[github-actions[bot]]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 7e40dff2c54b00187e9cffa73e62006701447968 and c596e53902c4835e4e6bfc467ef0c218039ec6b8.

tl;dr

Use these benchmarks as an insight tool during development.

1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            84.37µ ± 5%   86.98µ ± 4%       ~ (p=0.089 n=10)
api-gateway-kong-appsec.json                       65.65µ ± 5%   68.33µ ± 4%  +4.08% (p=0.011 n=10)
api-gateway-kong.json                              63.52µ ± 1%   66.30µ ± 2%  +4.38% (p=0.000 n=10)
api-gateway-non-proxy-async.json                   101.3µ ± 1%   105.5µ ± 1%  +4.14% (p=0.000 n=10)
api-gateway-non-proxy.json                         101.6µ ± 1%   105.9µ ± 2%  +4.16% (p=0.000 n=10)
api-gateway-websocket-connect.json                 67.65µ ± 1%   68.95µ ± 4%  +1.91% (p=0.001 n=10)
api-gateway-websocket-default.json                 61.13µ ± 2%   64.00µ ± 0%  +4.69% (p=0.000 n=10)
api-gateway-websocket-disconnect.json              61.61µ ± 1%   63.76µ ± 1%  +3.49% (p=0.000 n=10)
api-gateway.json                                   113.8µ ± 1%   117.9µ ± 1%  +3.61% (p=0.000 n=10)
application-load-balancer.json                     62.61µ ± 1%   64.29µ ± 1%  +2.68% (p=0.000 n=10)
cloudfront.json                                    46.93µ ± 5%   48.13µ ± 3%  +2.55% (p=0.015 n=10)
cloudwatch-events.json                             37.59µ ± 2%   38.32µ ± 1%  +1.92% (p=0.011 n=10)
cloudwatch-logs.json                               64.24µ ± 2%   67.13µ ± 2%  +4.49% (p=0.000 n=10)
custom.json                                        29.97µ ± 2%   31.25µ ± 2%  +4.29% (p=0.002 n=10)
dynamodb.json                                      93.79µ ± 1%   97.12µ ± 2%  +3.55% (p=0.000 n=10)
empty.json                                         28.54µ ± 2%   29.69µ ± 3%  +4.02% (p=0.000 n=10)
eventbridge-custom.json                            42.52µ ± 3%   42.29µ ± 3%       ~ (p=0.579 n=10)
http-api.json                                      72.83µ ± 1%   74.35µ ± 2%  +2.09% (p=0.043 n=10)
kinesis-batch.json                                 72.06µ ± 3%   72.50µ ± 2%       ~ (p=0.280 n=10)
kinesis.json                                       54.35µ ± 2%   54.94µ ± 3%       ~ (p=0.796 n=10)
s3.json                                            59.68µ ± 1%   60.02µ ± 1%       ~ (p=0.280 n=10)
sns-batch.json                                     93.46µ ± 3%   92.74µ ± 2%       ~ (p=0.481 n=10)
sns.json                                           65.65µ ± 1%   66.05µ ± 2%       ~ (p=0.280 n=10)
snssqs.json                                        110.9µ ± 2%   113.3µ ± 1%  +2.23% (p=0.005 n=10)
snssqs_no_dd_context.json                          98.39µ ± 2%   99.70µ ± 1%  +1.34% (p=0.002 n=10)
sqs-aws-header.json                                56.13µ ± 2%   55.69µ ± 2%       ~ (p=0.353 n=10)
sqs-batch.json                                     95.02µ ± 2%   96.81µ ± 2%  +1.89% (p=0.019 n=10)
sqs.json                                           69.42µ ± 2%   71.52µ ± 2%  +3.02% (p=0.005 n=10)
sqs_no_dd_context.json                             62.78µ ± 3%   62.20µ ± 3%       ~ (p=0.382 n=10)
geomean                                            66.32µ        67.86µ       +2.31%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.26Ki ± 0%   37.26Ki ± 0%       ~ (p=0.956 n=10)
api-gateway-kong-appsec.json                      26.92Ki ± 0%   26.92Ki ± 0%       ~ (p=0.810 n=10)
api-gateway-kong.json                             24.41Ki ± 0%   24.42Ki ± 0%       ~ (p=0.148 n=10)
api-gateway-non-proxy-async.json                  48.00Ki ± 0%   48.01Ki ± 0%       ~ (p=0.435 n=10)
api-gateway-non-proxy.json                        47.23Ki ± 0%   47.23Ki ± 0%       ~ (p=0.542 n=10)
api-gateway-websocket-connect.json                25.44Ki ± 0%   25.45Ki ± 0%       ~ (p=0.183 n=10)
api-gateway-websocket-default.json                21.34Ki ± 0%   21.36Ki ± 0%  +0.07% (p=0.020 n=10)
api-gateway-websocket-disconnect.json             21.12Ki ± 0%   21.14Ki ± 0%  +0.05% (p=0.017 n=10)
api-gateway.json                                  49.54Ki ± 0%   49.54Ki ± 0%       ~ (p=0.418 n=10)
application-load-balancer.json                    22.32Ki ± 0%   22.32Ki ± 0%       ~ (p=0.402 n=10)
cloudfront.json                                   17.64Ki ± 0%   17.64Ki ± 0%       ~ (p=0.183 n=10)
cloudwatch-events.json                            11.68Ki ± 0%   11.69Ki ± 0%       ~ (p=0.255 n=10)
cloudwatch-logs.json                              53.35Ki ± 0%   53.38Ki ± 0%  +0.04% (p=0.045 n=10)
custom.json                                       9.709Ki ± 0%   9.711Ki ± 0%       ~ (p=0.446 n=10)
dynamodb.json                                     40.67Ki ± 0%   40.70Ki ± 0%       ~ (p=0.055 n=10)
empty.json                                        9.269Ki ± 0%   9.291Ki ± 0%       ~ (p=0.055 n=10)
eventbridge-custom.json                           13.41Ki ± 0%   13.41Ki ± 0%       ~ (p=0.542 n=10)
http-api.json                                     23.70Ki ± 0%   23.71Ki ± 0%       ~ (p=0.306 n=10)
kinesis-batch.json                                27.02Ki ± 0%   27.01Ki ± 0%       ~ (p=0.279 n=10)
kinesis.json                                      17.79Ki ± 0%   17.80Ki ± 0%       ~ (p=0.105 n=10)
s3.json                                           20.33Ki ± 0%   20.34Ki ± 0%       ~ (p=0.955 n=10)
sns-batch.json                                    38.67Ki ± 0%   38.64Ki ± 0%       ~ (p=0.631 n=10)
sns.json                                          24.02Ki ± 0%   24.02Ki ± 0%       ~ (p=0.469 n=10)
snssqs.json                                       50.75Ki ± 0%   50.73Ki ± 0%       ~ (p=0.631 n=10)
snssqs_no_dd_context.json                         44.78Ki ± 0%   44.81Ki ± 0%       ~ (p=0.325 n=10)
sqs-aws-header.json                               18.81Ki ± 0%   18.82Ki ± 0%       ~ (p=0.755 n=10)
sqs-batch.json                                    41.64Ki ± 0%   41.66Ki ± 0%       ~ (p=0.448 n=10)
sqs.json                                          25.56Ki ± 1%   25.59Ki ± 0%       ~ (p=0.579 n=10)
sqs_no_dd_context.json                            20.73Ki ± 0%   20.68Ki ± 1%       ~ (p=0.075 n=10)
geomean                                           25.70Ki        25.70Ki       +0.02%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             630.0 ± 0%   629.5 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    725.0 ± 0%   725.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-disconnect.json               369.5 ± 0%   370.0 ± 0%  +0.14% (p=0.033 n=10)
api-gateway.json                                    791.0 ± 0%   791.0 ± 0%       ~ (p=0.721 n=10)
application-load-balancer.json                      352.0 ± 0%   352.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=0.474 n=10)
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=0.474 n=10)
cloudwatch-logs.json                                215.0 ± 0%   216.0 ± 0%       ~ (p=0.170 n=10)
custom.json                                         168.0 ± 0%   168.0 ± 0%       ~ (p=1.000 n=10)
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=0.365 n=10)
empty.json                                          159.0 ± 1%   160.0 ± 1%       ~ (p=0.170 n=10)
eventbridge-custom.json                             254.0 ± 0%   254.0 ± 0%       ~ (p=0.700 n=10)
http-api.json                                       432.0 ± 0%   432.5 ± 0%       ~ (p=0.650 n=10)
kinesis-batch.json                                  391.0 ± 0%   390.0 ± 0%       ~ (p=0.230 n=10)
kinesis.json                                        285.0 ± 0%   285.0 ± 0%       ~ (p=0.495 n=10)
s3.json                                             358.0 ± 0%   358.0 ± 1%       ~ (p=0.777 n=10)
sns-batch.json                                      455.0 ± 0%   455.0 ± 0%       ~ (p=0.797 n=10)
sns.json                                            324.0 ± 0%   324.0 ± 0%       ~ (p=0.904 n=10)
snssqs.json                                         450.0 ± 0%   450.0 ± 0%       ~ (p=0.963 n=10)
snssqs_no_dd_context.json                           399.0 ± 0%   399.5 ± 0%       ~ (p=0.201 n=10)
sqs-aws-header.json                                 274.0 ± 0%   274.0 ± 0%       ~ (p=0.997 n=10)
sqs-batch.json                                      503.5 ± 0%   504.0 ± 0%       ~ (p=0.440 n=10)
sqs.json                                            351.0 ± 1%   351.5 ± 0%       ~ (p=0.720 n=10)
sqs_no_dd_context.json                              325.0 ± 1%   324.5 ± 0%       ~ (p=0.140 n=10)
geomean                                             376.7        376.9       +0.04%
¹ all samples are equal

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38288196 --os-family=ubuntu

Note: This applies to commit 30677df4

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 4ccb1421-0cbb-47f3-aec6-62b1d6639ed0 Metrics dashboard Target profiles

Baseline: 6fce5ebd930883a65d6209013f205ea8b61196e4 Comparison: c425f40cce7e32ea0a51caad76bc5f572e0e834d

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.76	[+1.86, +3.66]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+1.81	[-11.15, +14.76]	Logs
➖	file_tree	memory utilization	+0.77	[+0.69, +0.86]	Logs
➖	idle	memory utilization	+0.29	[+0.25, +0.33]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.03, +0.03]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.05	[-0.86, +0.76]	Logs
➖	basic_py_check	% cpu utilization	-0.85	[-3.47, +1.77]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	-1.61	[-6.43, +3.22]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[paulcacheux]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!