Lint that newly added components use the new folder structure

[dustmop]

What does this PR do?

• Add an allowlist of existing components that use the classic component structure
• Add source tree in testdata that defines classic and new-style components
• Add a basic unit test for get_components_and_bundles, which many lint rules depend on
• Add TODOs for other things the linter should be checking in the new component layout
• Remove some components_to_migrate that currently pass the existing linters

Motivation

Enforcing consistency with the new components layout: https://datadoghq.dev/datadog-agent/components/creating-components/

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=39545551 --os-family=ubuntu

Note: This applies to commit 3a622509

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: c3bfba46-26fb-44d7-89fd-884f553b5b6d Metrics dashboard Target profiles

Baseline: 417a343c64a9dccb6bdb34b01c8ddaf1e20f8282 Comparison: 3a62250921ff86a44bf9497ad08ac4a91e743669

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	tcp_syslog_to_blackhole	ingress throughput	+0.57	[-12.13, +13.27]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	Logs
➖	idle	memory utilization	-0.10	[-0.14, -0.06]	Logs
➖	basic_py_check	% cpu utilization	-0.23	[-2.72, +2.27]	Logs
➖	file_tree	memory utilization	-0.69	[-0.76, -0.62]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.69	[-1.50, +0.12]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	-1.08	[-5.80, +3.63]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.16	[-2.08, -0.25]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[agent-platform-auto-pr[bot]]

[Fast Unit Tests Report]

On pipeline 39545551 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[dustmop]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!