datadog-agent
datadog-agent copied to clipboard
[CI] Add timeout over codecov binary to avoid random hang
What does this PR do?
This PR adds a 2min timeout to codecov binary exection.
Motivation
It's often hanging for 2 hours after it successfully uploads the coverage to Codecov. We don't know why, so until we update it (it's coming), let's just put a timeout on the ctx.run call.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Regression Detector
Regression Detector Results
Run ID: a265a389-47ef-4b68-8dc7-226f0a909b1c Metrics dashboard Target profiles
Baseline: e82159344869f51cc1ec23612222cacc1e5e841b Comparison: d885f46491e91aec6b454197edbc95d5778dbbbd
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +5.63 | [-7.46, +18.72] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.06 | [-0.75, +0.87] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
| ➖ | idle | memory utilization | -0.42 | [-0.45, -0.38] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.44 | [-1.33, +0.45] | Logs |
| ➖ | file_tree | memory utilization | -0.58 | [-0.67, -0.50] | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.68 | [-3.31, +1.94] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.91 | [-5.74, +3.91] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main is 25m.
Use /merge -c to cancel this operation!