datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CONTINT-3529] Add Windows fargate e2e tests

Open AliDatadog opened this issue 1 year ago • 5 comments

What does this PR do?

This PR adds an e2e test for a Windows workload on ECS Fargate. Were testing both the container check and the HTTP check. Logs are not supported.

Motivation

Improve E2E test coverage.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

AliDatadog avatar Jul 03 '24 14:07 AliDatadog

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38379636 --os-family=ubuntu

Note: This applies to commit bf079e75

pr-commenter[bot] avatar Jul 03 '24 14:07 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

AliDatadog avatar Jul 03 '24 15:07 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #38267136

dd-devflow[bot] avatar Jul 03 '24 15:07 dd-devflow[bot]

:steam_locomotive: Devflow: /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

dd-devflow[bot] avatar Jul 03 '24 15:07 dd-devflow[bot]

Regression Detector

Regression Detector Results

Run ID: 9da6604a-a383-4118-a731-ef96022e94da Metrics dashboard Target profiles

Baseline: 326743718d731cf8c3141189a81671be2d054c8e Comparison: bf079e759fcdde88f115222cfa23d144e45d7f84

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
uds_dogstatsd_to_api_cpu % cpu utilization +1.19 [+0.31, +2.08] Logs
file_tree memory utilization +0.58 [+0.47, +0.69] Logs
basic_py_check % cpu utilization +0.51 [-2.13, +3.15] Logs
idle memory utilization +0.13 [+0.08, +0.18] Logs
tcp_syslog_to_blackhole ingress throughput +0.05 [-12.58, +12.67] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
otel_to_otel_logs ingress throughput -0.09 [-0.90, +0.72] Logs
pycheck_1000_100byte_tags % cpu utilization -0.83 [-5.67, +4.01] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jul 03 '24 15:07 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

AliDatadog avatar Jul 04 '24 09:07 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #38359619

dd-devflow[bot] avatar Jul 04 '24 09:07 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

AliDatadog avatar Jul 04 '24 09:07 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #38360420

dd-devflow[bot] avatar Jul 04 '24 09:07 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

AliDatadog avatar Jul 04 '24 10:07 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #38364322

dd-devflow[bot] avatar Jul 04 '24 10:07 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

AliDatadog avatar Jul 04 '24 13:07 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #38379689

dd-devflow[bot] avatar Jul 04 '24 13:07 dd-devflow[bot]

/merge

L3n41c avatar Jul 04 '24 19:07 L3n41c

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Jul 04 '24 19:07 dd-devflow[bot]