remove StartServers method in favor of fx Lifecycle

[misteriaud]

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=39254066 --os-family=ubuntu

Note: This applies to commit 4cff4823

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 1d48f52a-9f1c-4cce-a78f-150da695c6b5 Metrics dashboard Target profiles

Baseline: 1e98dc7b641440331d1740fc23750e8dedb51e39 Comparison: 4cff482386975adb9689df2860499d00dd0d35f5

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	pycheck_1000_100byte_tags	% cpu utilization	+1.61	[-3.17, +6.39]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.75	[-12.22, +13.72]	Logs
➖	file_tree	memory utilization	+0.22	[+0.15, +0.29]	Logs
➖	idle	memory utilization	+0.02	[-0.01, +0.06]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.48	[-1.36, +0.40]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.82	[-1.63, -0.02]	Logs
➖	basic_py_check	% cpu utilization	-0.95	[-3.43, +1.54]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[GustavoCaso]

Amazing work 🎉

Wondering if it would be worth opening a separate PR to move the RCClient initialization to their lifecycle hooks?

[misteriaud]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!