What does this PR do?

This PR updates all collector dependencies to v0.104.0 except datadogconnector. datadogconnector cannot be upgraded because of breaking change in #26347.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Spin up agent with OTLP ingest with defaults and make sure the http/ grpc servers addresses are localhost instead of 0.0.0.0.

Jul 02 '24 14:07 mackjmr

Benchmarks

Benchmark execution time: 2024-07-02 14:10:50

Comparing candidate commit eb4c6e88261ade2bea7c1bfd6fe84e8901ce83ac in PR branch mackjmr/update-collector-104 with baseline commit a30e11cc4bc65345436170a340e335180b970e8c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 1 unstable metrics.

Jul 02 '24 14:07 pr-commenter[bot]

Go Package Import Differences

Baseline: ac1a2ac3575b907e47fd9e391052c7890c2c962f Comparison: e5c70b568b6ddf1e375bf58e5c93c688e1927f5a

binary	os	arch	change
agent	linux	amd64	+3, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix
agent	linux	arm64	+3, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix
agent	windows	amd64	+3, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix
agent	darwin	amd64	+3, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix
agent	darwin	arm64	+3, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix
iot-agent	linux	amd64	+3, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix
iot-agent	linux	arm64	+3, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix
heroku-agent	linux	amd64	+3, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix
serverless	linux	amd64	+4, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix +net/http/cookiejar
serverless	linux	arm64	+4, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix +net/http/cookiejar
trace-agent	linux	amd64	+4, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix +net/http/cookiejar
trace-agent	linux	arm64	+4, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix +net/http/cookiejar
trace-agent	windows	amd64	+4, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix +net/http/cookiejar
trace-agent	darwin	amd64	+4, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix +net/http/cookiejar
trace-agent	darwin	arm64	+4, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix +net/http/cookiejar
heroku-trace-agent	linux	amd64	+4, -8 -go.opentelemetry.io/collector/confmap/converter/expandconverter -go.opentelemetry.io/collector/confmap/internal/envvar -go.opentelemetry.io/collector/confmap/provider/envprovider -go.opentelemetry.io/collector/confmap/provider/fileprovider -go.opentelemetry.io/collector/confmap/provider/httpprovider -go.opentelemetry.io/collector/confmap/provider/httpsprovider -go.opentelemetry.io/collector/confmap/provider/internal/configurablehttpprovider -go.opentelemetry.io/collector/confmap/provider/yamlprovider +go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental +go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental +golang.org/x/net/publicsuffix +net/http/cookiejar

Jul 02 '24 14:07 cit-pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-02 14:31:20

Comparing candidate commit b95c6c1aadb084f0a59b25a25ebcf3289752d75c in PR branch mackjmr/update-collector-104 with baseline commit a30e11cc4bc65345436170a340e335180b970e8c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 1 unstable metrics.

Jul 02 '24 14:07 pr-commenter[bot]

We do need a QA to ensure the upstream breaking changes aren't impacting OTLP ingest in the Agent

Jul 02 '24 15:07 dineshg13

@dineshg13 I updated manifest.yaml and version in collector.yaml. I also added QA instructions, although I don't think there is anything to check other than the http/ grpc servers addresses are localhost instead of 0.0.0.0.

Jul 02 '24 15:07 mackjmr

Benchmarks

Benchmark execution time: 2024-07-02 15:34:35

Comparing candidate commit e9a09b6fde92feffdc40244c948e328d7e984bd7 in PR branch mackjmr/update-collector-104 with baseline commit a797f973ef2eba618a3997f399180b67d884ef0c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 1 unstable metrics.

Jul 02 '24 15:07 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 033fb88d-9426-4906-bbea-b438afa184e2 Metrics dashboard Target profiles

Baseline: ac1a2ac3575b907e47fd9e391052c7890c2c962f Comparison: e5c70b568b6ddf1e375bf58e5c93c688e1927f5a

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	pycheck_1000_100byte_tags	% cpu utilization	+3.12	[-1.74, +7.99]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.13	[-12.74, +12.99]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	idle	memory utilization	-0.02	[-0.06, +0.01]	Logs
➖	file_tree	memory utilization	-0.65	[-0.70, -0.59]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.67	[-1.48, +0.14]	Logs
➖	basic_py_check	% cpu utilization	-0.96	[-3.53, +1.62]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.68	[-2.56, -0.79]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Jul 02 '24 15:07 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38372399 --os-family=ubuntu

Note: This applies to commit 6ec844c4

Jul 02 '24 16:07 pr-commenter[bot]

We are using datadog connector 0.104.0 , but otherwise LGTM

It is replaced with 0.103.0 so shouldn't be a problem

Jul 02 '24 19:07 songy23

@dineshg13 @songy23

We are using datadog connector 0.104.0 , but otherwise LGTM

Are you talking about the version in manifest.yaml ? I can bump this down to 0.103.0 ?

Jul 03 '24 11:07 mackjmr

Benchmarks

Benchmark execution time: 2024-07-04 12:14:12

Comparing candidate commit 37fcac74b3007b09a7ee22347b4ec2241ee5be03 in PR branch mackjmr/update-collector-104 with baseline commit aca52e8b57d3e38a33bb769bdc1f3859711147f3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 04 '24 12:07 pr-commenter[bot]

@dineshg13 @songy23 We are using datadog connector 0.104.0 , but otherwise LGTM Are you talking about the version in manifest.yaml ? I can bump this down to 0.103.0 ?

I didn't realize inv collector.generate was removing the replace statement in comp/otelcol/collector-contrib/impl/go.mod. I've updated the datadogconnector in manifest.yaml to v0.103.0 with a todo. I've also updated the OCB version to v0.104.0 in manifest.yaml.

Jul 04 '24 12:07 mackjmr

Benchmarks

Benchmark execution time: 2024-07-04 12:24:27

Comparing candidate commit 6ec844c407cdce96a62c42670af33e8e5c687d7d in PR branch mackjmr/update-collector-104 with baseline commit aca52e8b57d3e38a33bb769bdc1f3859711147f3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 04 '24 12:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-04 12:24:42

Comparing candidate commit 6ec844c407cdce96a62c42670af33e8e5c687d7d in PR branch mackjmr/update-collector-104 with baseline commit aca52e8b57d3e38a33bb769bdc1f3859711147f3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 04 '24 12:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-04 13:26:50

Comparing candidate commit 6cfaac7aede628679fe6c140ccb25409f128556e in PR branch mackjmr/update-collector-104 with baseline commit 49523ca32574cc8b37acdfc71433427cee1af12f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 04 '24 13:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-05 09:00:20

Comparing candidate commit 6efdc596467439825a6ea927a2a8b123bc18b668 in PR branch mackjmr/update-collector-104 with baseline commit 7a5711213a05dabf903a9fde2c4edbb4ff9bdae5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 05 '24 09:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-05 09:03:42

Comparing candidate commit 6efdc596467439825a6ea927a2a8b123bc18b668 in PR branch mackjmr/update-collector-104 with baseline commit 7a5711213a05dabf903a9fde2c4edbb4ff9bdae5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 05 '24 09:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-05 09:05:39

Comparing candidate commit b88d7608fad04917c771c7de18e7ba25016c0f39 in PR branch mackjmr/update-collector-104 with baseline commit 7a5711213a05dabf903a9fde2c4edbb4ff9bdae5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 05 '24 09:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-05 09:06:26

Comparing candidate commit b88d7608fad04917c771c7de18e7ba25016c0f39 in PR branch mackjmr/update-collector-104 with baseline commit 7a5711213a05dabf903a9fde2c4edbb4ff9bdae5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 05 '24 09:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-05 14:01:25

Comparing candidate commit 75f750017de2550a0388b313a236f4b621ba27b5 in PR branch mackjmr/update-collector-104 with baseline commit b8e0e1276a6ca4e92fe01cc9ae77fe6016c01b76 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 05 '24 14:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-05 14:07:03

Comparing candidate commit 3d916b570890f39063da44f2122ce205a8eff46a in PR branch mackjmr/update-collector-104 with baseline commit 8d427d744d4de771dee8d7bcaf285156ce4a3f1c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 05 '24 14:07 pr-commenter[bot]

Benchmarks

Benchmark execution time: 2024-07-05 14:39:05

Comparing candidate commit e5c70b568b6ddf1e375bf58e5c93c688e1927f5a in PR branch mackjmr/update-collector-104 with baseline commit 5cabbd505727234b911b6729a4e4e691f8f33150 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Jul 05 '24 14:07 pr-commenter[bot]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 5cabbd505727234b911b6729a4e4e691f8f33150 and 26b0bde3414e7ba133bbe8df9f736f74bfabaf14.

tl;dr

Use these benchmarks as an insight tool during development.

Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.
The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            89.49µ ± 6%   83.87µ ± 9%  -6.28% (p=0.043 n=10)
api-gateway-kong-appsec.json                       69.55µ ± 2%   66.44µ ± 5%  -4.47% (p=0.007 n=10)
api-gateway-kong.json                              68.44µ ± 2%   64.04µ ± 1%  -6.42% (p=0.000 n=10)
api-gateway-non-proxy-async.json                   109.8µ ± 1%   103.2µ ± 2%  -6.04% (p=0.000 n=10)
api-gateway-non-proxy.json                         110.0µ ± 2%   103.7µ ± 1%  -5.69% (p=0.000 n=10)
api-gateway-websocket-connect.json                 71.93µ ± 2%   69.79µ ± 2%  -2.97% (p=0.000 n=10)
api-gateway-websocket-default.json                 64.93µ ± 2%   61.90µ ± 2%  -4.67% (p=0.000 n=10)
api-gateway-websocket-disconnect.json              64.18µ ± 2%   62.31µ ± 2%  -2.91% (p=0.000 n=10)
api-gateway.json                                   120.1µ ± 3%   115.0µ ± 2%  -4.21% (p=0.001 n=10)
application-load-balancer.json                     64.86µ ± 2%   62.97µ ± 1%  -2.91% (p=0.000 n=10)
cloudfront.json                                    49.13µ ± 3%   47.43µ ± 2%  -3.46% (p=0.015 n=10)
cloudwatch-events.json                             38.99µ ± 3%   37.94µ ± 1%  -2.70% (p=0.007 n=10)
cloudwatch-logs.json                               68.59µ ± 2%   65.87µ ± 1%  -3.96% (p=0.000 n=10)
custom.json                                        31.68µ ± 1%   30.53µ ± 2%  -3.63% (p=0.000 n=10)
dynamodb.json                                      99.58µ ± 1%   95.17µ ± 2%  -4.43% (p=0.002 n=10)
empty.json                                         30.97µ ± 3%   28.58µ ± 2%  -7.71% (p=0.000 n=10)
eventbridge-custom.json                            44.30µ ± 2%   42.10µ ± 2%  -4.97% (p=0.001 n=10)
http-api.json                                      77.15µ ± 2%   72.23µ ± 1%  -6.38% (p=0.000 n=10)
kinesis-batch.json                                 76.86µ ± 3%   70.80µ ± 1%  -7.89% (p=0.000 n=10)
kinesis.json                                       57.28µ ± 3%   54.31µ ± 2%  -5.20% (p=0.000 n=10)
s3.json                                            62.99µ ± 2%   59.24µ ± 2%  -5.96% (p=0.000 n=10)
sns-batch.json                                     96.33µ ± 2%   89.69µ ± 2%  -6.89% (p=0.000 n=10)
sns.json                                           68.50µ ± 3%   64.57µ ± 1%  -5.73% (p=0.000 n=10)
snssqs.json                                        122.4µ ± 3%   111.9µ ± 2%  -8.60% (p=0.000 n=10)
snssqs_no_dd_context.json                         107.92µ ± 2%   97.99µ ± 1%  -9.21% (p=0.000 n=10)
sqs-aws-header.json                                60.06µ ± 1%   55.43µ ± 2%  -7.71% (p=0.000 n=10)
sqs-batch.json                                    101.18µ ± 3%   94.45µ ± 1%  -6.65% (p=0.000 n=10)
sqs.json                                           73.52µ ± 2%   69.96µ ± 2%  -4.84% (p=0.000 n=10)
sqs_no_dd_context.json                             67.74µ ± 3%   61.89µ ± 2%  -8.64% (p=0.000 n=10)
geomean                                            70.44µ        66.51µ       -5.57%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.26Ki ± 0%   37.26Ki ± 0%       ~ (p=0.109 n=10)
api-gateway-kong-appsec.json                      26.92Ki ± 0%   26.92Ki ± 0%       ~ (p=0.897 n=10)
api-gateway-kong.json                             24.42Ki ± 0%   24.41Ki ± 0%       ~ (p=0.147 n=10)
api-gateway-non-proxy-async.json                  48.02Ki ± 0%   48.01Ki ± 0%       ~ (p=0.197 n=10)
api-gateway-non-proxy.json                        47.24Ki ± 0%   47.22Ki ± 0%       ~ (p=0.060 n=10)
api-gateway-websocket-connect.json                25.45Ki ± 0%   25.45Ki ± 0%       ~ (p=0.066 n=10)
api-gateway-websocket-default.json                21.36Ki ± 0%   21.35Ki ± 0%       ~ (p=0.136 n=10)
api-gateway-websocket-disconnect.json             21.14Ki ± 0%   21.14Ki ± 0%       ~ (p=0.445 n=10)
api-gateway.json                                  49.55Ki ± 0%   49.54Ki ± 0%       ~ (p=0.086 n=10)
application-load-balancer.json                    22.32Ki ± 0%   22.32Ki ± 0%       ~ (p=0.078 n=10)
cloudfront.json                                   17.65Ki ± 0%   17.65Ki ± 0%       ~ (p=0.565 n=10)
cloudwatch-events.json                            11.69Ki ± 0%   11.69Ki ± 0%       ~ (p=0.447 n=10)
cloudwatch-logs.json                              53.38Ki ± 0%   53.37Ki ± 0%  -0.02% (p=0.007 n=10)
custom.json                                       9.728Ki ± 0%   9.710Ki ± 0%       ~ (p=0.143 n=10)
dynamodb.json                                     40.70Ki ± 0%   40.67Ki ± 0%       ~ (p=0.159 n=10)
empty.json                                        9.284Ki ± 0%   9.279Ki ± 0%       ~ (p=0.481 n=10)
eventbridge-custom.json                           13.42Ki ± 0%   13.40Ki ± 0%       ~ (p=0.288 n=10)
http-api.json                                     23.73Ki ± 0%   23.69Ki ± 0%  -0.15% (p=0.019 n=10)
kinesis-batch.json                                27.03Ki ± 0%   27.01Ki ± 0%       ~ (p=0.184 n=10)
kinesis.json                                      17.83Ki ± 0%   17.80Ki ± 0%       ~ (p=0.159 n=10)
s3.json                                           20.35Ki ± 0%   20.33Ki ± 0%       ~ (p=0.353 n=10)
sns-batch.json                                    38.69Ki ± 0%   38.66Ki ± 0%  -0.09% (p=0.050 n=10)
sns.json                                          24.00Ki ± 0%   23.98Ki ± 0%       ~ (p=0.494 n=10)
snssqs.json                                       50.83Ki ± 0%   50.76Ki ± 0%       ~ (p=0.105 n=10)
snssqs_no_dd_context.json                         44.85Ki ± 0%   44.82Ki ± 0%       ~ (p=0.447 n=10)
sqs-aws-header.json                               18.80Ki ± 0%   18.82Ki ± 0%       ~ (p=0.699 n=10)
sqs-batch.json                                    41.68Ki ± 1%   41.56Ki ± 0%       ~ (p=0.436 n=10)
sqs.json                                          25.57Ki ± 0%   25.57Ki ± 1%       ~ (p=0.956 n=10)
sqs_no_dd_context.json                            20.71Ki ± 1%   20.67Ki ± 1%       ~ (p=0.393 n=10)
geomean                                           25.71Ki        25.70Ki       -0.06%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             629.5 ± 0%   629.5 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    726.0 ± 0%   725.0 ± 0%       ~ (p=0.656 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=0.474 n=10)
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=0.474 n=10)
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json               370.0 ± 0%   370.0 ± 0%       ~ (p=1.000 n=10)
api-gateway.json                                    791.0 ± 0%   791.0 ± 0%       ~ (p=1.000 n=10)
application-load-balancer.json                      352.0 ± 0%   352.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=1.000 n=10)
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=0.474 n=10)
cloudwatch-logs.json                                216.0 ± 0%   215.5 ± 0%       ~ (p=0.237 n=10)
custom.json                                         168.0 ± 0%   168.0 ± 0%       ~ (p=1.000 n=10)
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=0.303 n=10)
empty.json                                          160.0 ± 1%   160.0 ± 1%       ~ (p=1.000 n=10)
eventbridge-custom.json                             254.0 ± 0%   254.0 ± 0%       ~ (p=1.000 n=10)
http-api.json                                       433.0 ± 0%   432.0 ± 0%  -0.23% (p=0.015 n=10)
kinesis-batch.json                                  391.0 ± 0%   390.5 ± 0%       ~ (p=0.104 n=10)
kinesis.json                                        285.5 ± 1%   285.0 ± 0%  -0.18% (p=0.029 n=10)
s3.json                                             358.0 ± 0%   358.0 ± 0%       ~ (p=0.736 n=10)
sns-batch.json                                      456.0 ± 0%   455.0 ± 0%  -0.22% (p=0.034 n=10)
sns.json                                            323.5 ± 0%   323.0 ± 0%       ~ (p=0.507 n=10)
snssqs.json                                         451.5 ± 1%   450.0 ± 0%       ~ (p=0.061 n=10)
snssqs_no_dd_context.json                           400.5 ± 0%   400.0 ± 0%       ~ (p=0.291 n=10)
sqs-aws-header.json                                 273.5 ± 1%   274.0 ± 0%       ~ (p=0.989 n=10)
sqs-batch.json                                      504.0 ± 1%   502.0 ± 0%       ~ (p=0.251 n=10)
sqs.json                                            351.0 ± 1%   351.0 ± 1%       ~ (p=0.900 n=10)
sqs_no_dd_context.json                              325.0 ± 1%   324.0 ± 1%       ~ (p=0.458 n=10)
geomean                                             377.0        376.7       -0.08%
¹ all samples are equal

Jul 05 '24 14:07 github-actions[bot]

/merge

Jul 05 '24 15:07 mackjmr

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

Jul 05 '24 15:07 dd-devflow[bot]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

Jul 05 '24 16:07 dd-devflow[bot]

:rotating_light: MergeQueue: This merge request is in error

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #devflow with those details!

Jul 05 '24 17:07 dd-devflow[bot]

/merge

Jul 05 '24 18:07 KSerrania

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

Jul 05 '24 18:07 dd-devflow[bot]

datadog-agent
datadog-agent copied to clipboard

Update collector to v0.104.0

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Benchmarks

Go Package Import Differences

Benchmarks

Benchmarks

Regression Detector

Regression Detector Results

No significant changes in experiment optimization goals

Fine details of change detection per experiment

Explanation

Test changes on VM

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Serverless Benchmark Results

datadog-agent datadog-agent copied to clipboard

Update collector to v0.104.0

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Benchmarks

Go Package Import Differences

Benchmarks

Benchmarks

Regression Detector

Regression Detector Results

No significant changes in experiment optimization goals

Fine details of change detection per experiment

Explanation

Test changes on VM

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Benchmarks

Serverless Benchmark Results

datadog-agent
datadog-agent copied to clipboard