datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Install different allocators

Open StephenWakely opened this issue 1 year ago • 2 comments
trafficstars

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

StephenWakely avatar Jul 02 '24 13:07 StephenWakely

[Fast Unit Tests Report]

On pipeline 41577569 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Regression Detector

Regression Detector Results

Run ID: a71b562e-112a-46cd-ae25-455457886609 Metrics dashboard Target profiles

Baseline: 47102895ec8861c0bf41e35e654fe999b4163106 Comparison: ff0aae835f95b64b3f97b2d6c5b3e5cdc01fee86

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
pycheck_1000_100byte_tags % cpu utilization +1.94 [-2.98, +6.87] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.91 [+1.02, +2.81] Logs
otel_to_otel_logs ingress throughput +0.67 [-0.15, +1.48] Logs
idle memory utilization +0.32 [+0.27, +0.37] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
file_tree memory utilization -0.58 [-0.69, -0.48] Logs
basic_py_check % cpu utilization -0.87 [-3.47, +1.74] Logs
tcp_syslog_to_blackhole ingress throughput -4.76 [-17.16, +7.63] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jul 02 '24 15:07 pr-commenter[bot]