datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-1924] Improve error printing and help messages in the Agent GUI

Open misteriaud opened this issue 1 year ago • 1 comments

What does this PR do?

This PR enhances the error messages displayed to the customer for scenarios such as invalid token, session expired, or Agent unreachable.

Here is an example of the page displayed to the user when logged out: Screenshot 2024-07-02 at 11 19 36

Motivation

This PR aims to provide better information in case of errors when using the GUI.

Describe how to test/QA your changes

  • (run the Agent)
  • run the command datadog-agent launch-gui
  • check that everything is working as before
  • add a session expiration with the following parameter in datadog.yaml : GUI_session_expiration: 20s
  • restart the Agent
  • run the command datadog-agent launch-gui
  • check that after ~20s you get the error displayed

misteriaud avatar Jul 01 '24 15:07 misteriaud

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38485419 --os-family=ubuntu

Note: This applies to commit f84ed81d

pr-commenter[bot] avatar Jul 01 '24 16:07 pr-commenter[bot]

/merge

misteriaud avatar Jul 06 '24 08:07 misteriaud

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 26m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Jul 06 '24 08:07 dd-devflow[bot]