datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Add ConfigStore Component

Open mackjmr opened this issue 1 year ago • 3 comments

What does this PR do?

The ConfigStore component stores and provides the otelcol configs. The configs are fetched at collector start in the collector component, and are read by the Datadog extension. It stores and provides both the user and enhanced configurations. The returned configs are effective + redacted configs.

Motivation

https://datadoghq.atlassian.net/browse/OASIS-53

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Launch the converged agent. Then run curl -k https://localhost:7777/ and make sure that the user and enhanced config are correct based on the passed configuration, and also make sure that any sensitive fields are redacted with '[REDACTED]'

mackjmr avatar Jun 27 '24 12:06 mackjmr

Regression Detector

Regression Detector Results

Run ID: 20838f9b-42fb-456c-8bec-e080b6aff528 Metrics dashboard Target profiles

Baseline: 3945ba0bd9cb34d0c45210c3005772a731c0af31 Comparison: 61088ec36c8deb0d8539141b0629a219d5854023

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
pycheck_1000_100byte_tags % cpu utilization +2.97 [-1.84, +7.78] Logs
otel_to_otel_logs ingress throughput +0.30 [-0.51, +1.11] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
file_tree memory utilization -0.07 [-0.11, -0.02] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.32 [-1.20, +0.57] Logs
idle memory utilization -0.66 [-0.70, -0.63] Logs
tcp_syslog_to_blackhole ingress throughput -1.05 [-13.76, +11.65] Logs
basic_py_check % cpu utilization -1.13 [-3.75, +1.49] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jun 27 '24 13:06 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38357626 --os-family=ubuntu

Note: This applies to commit d4926ced

pr-commenter[bot] avatar Jun 28 '24 10:06 pr-commenter[bot]

@hush-hush added a description + QA instructions 👍

mackjmr avatar Jul 01 '24 12:07 mackjmr

Discussed with @dineshg13 offline, remaining comments will be addressed in a separate PR and will merge this as is.

mackjmr avatar Jul 04 '24 13:07 mackjmr

/merge

mackjmr avatar Jul 04 '24 13:07 mackjmr

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Jul 04 '24 13:07 dd-devflow[bot]