Implement Python API for submitting logs
Motivation
Expose the new functionality to Python checks https://github.com/DataDog/datadog-agent/pull/26753
Additional Notes
After the base PR is merged this PR will re-target main
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=40520993 --os-family=ubuntu
Note: This applies to commit a775579d
Regression Detector
Regression Detector Results
Run ID: 17736aeb-9360-4daa-92b7-fbc816faa9fb Metrics dashboard Target profiles
Baseline: fc52f43ddc69d9adcc586009d7c4c7b102ad7e6d Comparison: a775579d74f8cbf1e6ec4e36e2c22b5e4c9ae7ed
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +0.10 | [-0.71, +0.91] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
| ➖ | file_tree | memory utilization | -0.41 | [-0.49, -0.33] | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.63 | [-3.14, +1.88] | Logs |
| ➖ | idle | memory utilization | -0.64 | [-0.68, -0.60] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.21 | [-3.09, -1.32] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -2.22 | [-6.90, +2.45] | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -3.93 | [-16.32, +8.46] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
I realized that most of my comments are about code from https://github.com/DataDog/datadog-agent/pull/26753 which is already merged, you might want to pull main to remove those commits
/merge
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main is 22m.
Use /merge -c to cancel this operation!
:rotating_light: MergeQueue: This merge request is in error
Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.
If you need support, contact us on Slack #devflow with those details!
/merge
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main is 22m.
Use /merge -c to cancel this operation!