add service_discovery system-probe module

[rarguelloF]

What does this PR do?

This PR adds a new service_discovery module to system-probe. This module is enabled by default (same as the service_discovery corecheck), linux only and exposes 2 endpoints:

• /service_discovery/open_ports -> returns the open ports in the current host.
• /service_discovery/procs/{pid} -> returns information about the proc with the given pid.

Motivation

This functionality was in the service_discovery check itself, but it requires root level permissions, so it has been moved to system-probe.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[cit-pr-commenter[bot]]

Go Package Import Differences

Baseline: a058d0500e0c5ce7c909d0987c630e0080a429c3 Comparison: 57a02ddfafb6202700ba5a32cc5884358756ccd0

binary	os	arch	change
agent	linux	amd64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
agent	linux	arm64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
agent	windows	amd64	+1, -3 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model -go4.org/mem -hash/maphash
agent	darwin	amd64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
agent	darwin	arm64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
iot-agent	linux	amd64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
iot-agent	linux	arm64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
heroku-agent	linux	amd64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
cluster-agent	linux	amd64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
cluster-agent	linux	arm64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
process-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
process-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
process-agent	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
heroku-process-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model
system-probe	linux	amd64	+4, -0 +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/systemprobe +go4.org/mem
system-probe	linux	arm64	+4, -0 +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/portlist +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/systemprobe +go4.org/mem
system-probe	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: e029f2dd-48b4-4e2a-a697-8de116ce991c Metrics dashboard Target profiles

Baseline: a058d0500e0c5ce7c909d0987c630e0080a429c3 Comparison: 57a02ddfafb6202700ba5a32cc5884358756ccd0

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	tcp_syslog_to_blackhole	ingress throughput	+6.83	[-6.50, +20.16]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	+1.07	[-3.71, +5.84]	Logs
➖	otel_to_otel_logs	ingress throughput	+0.13	[-0.68, +0.94]	Logs
➖	file_tree	memory utilization	+0.12	[+0.04, +0.20]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	Logs
➖	idle	memory utilization	-0.05	[-0.09, -0.01]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.17	[-1.05, +0.71]	Logs
➖	basic_py_check	% cpu utilization	-2.26	[-4.91, +0.39]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37713785 --os-family=ubuntu

Note: This applies to commit 57a02ddf

[jonbodner]

This work in on hold. Closing this PR.