[SNMP] Ping instance config should override init_config settings

[ken-schneider]

trafficstars

What does this PR do?

Fixes behavior where init_config for ping would override any instance level config set for a device. It should be the other way around, e.g. if ping is generally enabled at the init_config level, but an instance has ping disabled, that instance should have ping disabled. Before this change, it would still be enabled.

Motivation

Noticed the behavior during some local testing. While this behavior is technically valid, it's at odds with the way other configs inside the SNMP integration work today.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.52%. Comparing base (fb139ec) to head (3450a0e). Report is 33 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #26348       +/-   ##
===========================================
+ Coverage   44.96%   50.52%    +5.55%     
===========================================
  Files        2353      108     -2245     
  Lines      272670     9940   -262730     
===========================================
- Hits       122614     5022   -117592     
+ Misses     140385     4745   -135640     
+ Partials     9671      173     -9498     

Flag	Coverage Δ
amzn_aarch64	50.55% <100.00%> (+4.75%)	:arrow_up:
centos_x86_64	50.59% <100.00%> (+4.87%)	:arrow_up:
ubuntu_aarch64	50.55% <100.00%> (+4.74%)	:arrow_up:
ubuntu_x86_64	50.59% <100.00%> (+4.78%)	:arrow_up:
windows_amd64	55.79% <100.00%> (+4.99%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38600708 --os-family=ubuntu

Note: This applies to commit 26ba128d

[ken-schneider]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:warning: MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

[ken-schneider]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: dd8d27fa-1296-489e-af94-0caed4002cee Metrics dashboard Target profiles

Baseline: b094406496ccd67c6381106392a96921ed7391d4 Comparison: 1ffe2ef367818ead4639ae5158455a5e5fe2126a

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	tcp_syslog_to_blackhole	ingress throughput	+4.02	[-8.89, +16.93]	Logs
➖	basic_py_check	% cpu utilization	+0.72	[-1.86, +3.31]	Logs
➖	otel_to_otel_logs	ingress throughput	+0.43	[-0.39, +1.24]	Logs
➖	idle	memory utilization	+0.22	[+0.18, +0.26]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	-0.23	[-5.03, +4.56]	Logs
➖	file_tree	memory utilization	-0.40	[-0.44, -0.36]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.50	[-1.39, +0.38]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[dd-devflow[bot]]

:warning: MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

[ken-schneider]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:warning: MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

[ken-schneider]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[bits-bot]

All committers have signed the CLA.

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 26m.

Use /merge -c to cancel this operation!