Renaming Oracle check

[nenadnoveljic]

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[cit-pr-commenter[bot]]

Go Package Import Differences

Baseline: e6ec7d50e5bc4cf483e8e877ad24c4159d972996 Comparison: 11287c2dbe66d5b290ff1183fe0ae6372ff65522

binary	os	arch	change
agent	linux	amd64	+3, -3 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agent	linux	arm64	+3, -3 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agent	windows	amd64	+3, -3 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agent	windows	386	+3, -3 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agent	darwin	amd64	+3, -3 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agent	darwin	arm64	+3, -3 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
iot-agent	linux	amd64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
iot-agent	linux	arm64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
heroku-agent	linux	amd64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
cluster-agent	linux	amd64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
cluster-agent	linux	arm64	+1, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm +github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30588388 --os-family=ubuntu

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 038843e4-c148-4cbe-af29-eb6dd1e77184 Baseline: f68d66a6539700f54268540842c4c215d29e3067 Comparison: 60772180476e26ebc8776ad8cb9e7de1dd01c9b2

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-1.60	[-7.87, +4.67]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	pycheck_1000_100byte_tags	% cpu utilization	+0.64	[-4.24, +5.53]
➖	process_agent_real_time_mode	memory utilization	+0.52	[+0.47, +0.56]
➖	process_agent_standard_check_with_stats	memory utilization	+0.48	[+0.44, +0.51]
➖	trace_agent_json	ingress throughput	+0.05	[+0.01, +0.08]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.20, +0.20]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.04, +0.02]
➖	trace_agent_msgpack	ingress throughput	-0.02	[-0.02, -0.01]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.13	[-2.90, +2.63]
➖	otel_to_otel_logs	ingress throughput	-0.13	[-0.59, +0.32]
➖	process_agent_standard_check	memory utilization	-0.16	[-0.20, -0.11]
➖	basic_py_check	% cpu utilization	-0.40	[-2.75, +1.95]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.42	[-0.52, -0.32]
➖	idle	memory utilization	-0.67	[-0.71, -0.62]
➖	file_to_blackhole	% cpu utilization	-1.60	[-7.87, +4.67]
➖	file_tree	memory utilization	-2.43	[-2.54, -2.32]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[vickenty]

Please also update paths in .github/CODEOWNERS

[nenadnoveljic]

Please also update paths in .github/CODEOWNERS

Done, thanks!

[nenadnoveljic]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[nenadnoveljic]

/merge

[dd-devflow[bot]]

:x: MergeQueue

PR is already in db with waiting status

If you need support, contact us on Slack #ci-interfaces with those details!

[dd-devflow[bot]]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

[nenadnoveljic]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!