datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[network_path] Use max ttl 30 & force to IPv4

Open AlexandreYang opened this issue 1 year ago • 2 comments

What does this PR do?

[network_path] Use max ttl 30

Motivation

TTL 15 is too low for most destinations.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

AlexandreYang avatar Mar 15 '24 16:03 AlexandreYang

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30204836 --os-family=ubuntu

pr-commenter[bot] avatar Mar 15 '24 17:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: ce12e493-6556-41a9-85bf-9bc1d61bda28 Baseline: bded4704d202a57d664a8d24b5bb73e4c196b912 Comparison: 8c2718196e62c0ca97c839d143ad40201a78e58a

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -2.60 [-8.90, +3.71]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.67 [-2.04, +3.37]
file_tree memory utilization +0.36 [+0.26, +0.45]
tcp_syslog_to_blackhole ingress throughput +0.34 [+0.25, +0.43]
basic_py_check % cpu utilization +0.24 [-2.09, +2.58]
trace_agent_msgpack ingress throughput +0.02 [-0.00, +0.04]
trace_agent_json ingress throughput -0.01 [-0.03, +0.02]
uds_dogstatsd_to_api ingress throughput -0.02 [-0.22, +0.19]
tcp_dd_logs_filter_exclude ingress throughput -0.03 [-0.07, +0.01]
otel_to_otel_logs ingress throughput -0.08 [-0.55, +0.40]
process_agent_standard_check memory utilization -0.13 [-0.16, -0.10]
process_agent_real_time_mode memory utilization -0.16 [-0.19, -0.13]
idle memory utilization -0.16 [-0.20, -0.12]
process_agent_standard_check_with_stats memory utilization -0.37 [-0.40, -0.35]
file_to_blackhole % cpu utilization -2.60 [-8.90, +3.71]
pycheck_1000_100byte_tags % cpu utilization -3.95 [-8.72, +0.82]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 15 '24 18:03 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on

AlexandreYang avatar Mar 20 '24 21:03 AlexandreYang

:steam_locomotive: Gitlab pipeline started

Started pipeline #30508113

dd-devflow[bot] avatar Mar 20 '24 21:03 dd-devflow[bot]