datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[USMON-802] usm: http2: Ignore query parameters

Open vitkyrka opened this issue 1 year ago • 2 comments

What does this PR do?

Makes USM's HTTP/2 implementation strip out the query string portion of the URL and adds a test case for this.

Motivation

To have the same behaviour as the HTTP/1.1 implementation.

https://datadoghq.atlassian.net/browse/USMON-802

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

vitkyrka avatar Mar 15 '24 13:03 vitkyrka

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30178723 --os-family=ubuntu

pr-commenter[bot] avatar Mar 15 '24 14:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 5524642a-64e8-484b-a27a-bb6f933947ce Baseline: 467d72b307e1779a99cd5519ead682e90afefd0c Comparison: 9daa464c0faf714d42f9983c22cb12a9d60f445a

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.92 [-7.23, +5.39]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +2.68 [-2.31, +7.67]
uds_dogstatsd_to_api_cpu % cpu utilization +1.05 [-1.68, +3.79]
tcp_syslog_to_blackhole ingress throughput +0.83 [+0.75, +0.92]
process_agent_standard_check_with_stats memory utilization +0.12 [+0.08, +0.17]
process_agent_real_time_mode memory utilization +0.11 [+0.08, +0.15]
trace_agent_json ingress throughput +0.01 [-0.03, +0.05]
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.22]
trace_agent_msgpack ingress throughput +0.01 [-0.01, +0.02]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.04, +0.01]
otel_to_otel_logs ingress throughput -0.02 [-0.44, +0.40]
idle memory utilization -0.09 [-0.12, -0.05]
process_agent_standard_check memory utilization -0.40 [-0.43, -0.36]
file_tree memory utilization -0.45 [-0.53, -0.36]
basic_py_check % cpu utilization -0.90 [-3.37, +1.56]
file_to_blackhole % cpu utilization -0.92 [-7.23, +5.39]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 15 '24 15:03 pr-commenter[bot]

/merge

vitkyrka avatar Mar 18 '24 09:03 vitkyrka

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 18 '24 09:03 dd-devflow[bot]