datadog-agent
datadog-agent copied to clipboard
[NPM] Fix propagating DefaultKProbeMaxActive to CO-RE tracer
What does this PR do?
Fix passing DefaultKProbeMaxActive
while loading CO-RE tracer. We moved over to using this option in https://github.com/DataDog/datadog-agent/commit/6da3631fafae36180a71e98bb5803122e950c5e4, but did not fix this code, resulting in max active actually not being set on the kretprobes when CO-RE is used.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=30149022 --os-family=ubuntu
Regression Detector
Regression Detector Results
Run ID: 9084403a-38c7-4187-9c2c-10338e84b5d4 Baseline: 3eb84063ab03066086a6578f9302aecb56598ff2 Comparison: b333e2753ce270c8d9d0ed01551cb2775dc6b065
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -0.67 | [-7.02, +5.68] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.35 | [+1.25, +1.45] |
➖ | file_tree | memory utilization | +0.98 | [+0.89, +1.06] |
➖ | idle | memory utilization | +0.27 | [+0.23, +0.31] |
➖ | basic_py_check | % cpu utilization | +0.16 | [-2.37, +2.68] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.10 | [+0.07, +0.13] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.05 | [-0.16, +0.26] |
➖ | trace_agent_msgpack | ingress throughput | +0.02 | [+0.01, +0.03] |
➖ | trace_agent_json | ingress throughput | -0.01 | [-0.03, +0.02] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.01] |
➖ | process_agent_standard_check | memory utilization | -0.04 | [-0.07, +0.00] |
➖ | process_agent_real_time_mode | memory utilization | -0.06 | [-0.09, -0.02] |
➖ | otel_to_otel_logs | ingress throughput | -0.19 | [-0.61, +0.23] |
➖ | file_to_blackhole | % cpu utilization | -0.67 | [-7.02, +5.68] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.44 | [-6.32, +3.45] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.60 | [-4.29, +1.08] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is going to start soon! (estimated merge in less than 28m)
Use /merge -c
to cancel this operation!