datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CI] Add `source /root/.bashrc` on `ebpf` jobs

Open amenasria opened this issue 1 year ago • 2 comments

What does this PR do?

This PR adds a source /root/.bashrc on ebpf jobs.

Motivation

This is needed for https://github.com/DataDog/datadog-agent-buildimages/pull/547.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

amenasria avatar Mar 14 '24 17:03 amenasria

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30362350 --os-family=ubuntu

pr-commenter[bot] avatar Mar 14 '24 18:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 1d344bed-6552-4e29-b2d7-9fe735dde921 Baseline: 2a4205a56880483ea75abb8de5c8b639ca7ba991 Comparison: d68adc9a1d468eb41aab908408a83d1a1df56df0

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.23 [-5.16, +7.63]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.23 [-5.16, +7.63]
uds_dogstatsd_to_api_cpu % cpu utilization +0.97 [-1.83, +3.76]
basic_py_check % cpu utilization +0.95 [-1.50, +3.40]
process_agent_real_time_mode memory utilization +0.29 [+0.26, +0.32]
process_agent_standard_check memory utilization +0.26 [+0.22, +0.29]
pycheck_1000_100byte_tags % cpu utilization +0.12 [-4.78, +5.01]
tcp_dd_logs_filter_exclude ingress throughput +0.03 [+0.00, +0.06]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.21]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.00 [-0.04, +0.04]
idle memory utilization -0.03 [-0.06, +0.00]
file_tree memory utilization -0.04 [-0.13, +0.05]
otel_to_otel_logs ingress throughput -0.17 [-0.61, +0.26]
tcp_syslog_to_blackhole ingress throughput -0.21 [-0.29, -0.13]
process_agent_standard_check_with_stats memory utilization -0.24 [-0.28, -0.21]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 14 '24 19:03 pr-commenter[bot]

[Fast Unit Tests Report]

On pipeline 30362350 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

/merge

amenasria avatar Mar 20 '24 11:03 amenasria

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 20 '24 11:03 dd-devflow[bot]