datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[SBOM] Disable HistoryDockerfile analyzer

Open 0intro opened this issue 1 year ago • 2 comments

What does this PR do?

This change disables the HistoryDockerfile analyzer,

This misconfiguration analyzer was added in Trivy on 2023-01-30. This was part of the recent bump of Trivy to version 2024-02-28.

However, misconfiguration analyzers were disabled in our version of Trivy, because they depend on the trivy-iac library, which allocates very large structures at init time.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

0intro avatar Mar 13 '24 21:03 0intro

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30068584 --os-family=ubuntu

pr-commenter[bot] avatar Mar 13 '24 22:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 4cb5de45-333c-4f5b-8c58-d46859e41fae Baseline: 30f826b9b34caecaa3995e5f0fdcfc28c7e4dadd Comparison: eaf70a328ad1cbb9ab01112cecaee7c08aade516

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.40 [-6.98, +6.17]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +2.65 [-2.55, +7.85]
uds_dogstatsd_to_api_cpu % cpu utilization +2.63 [-0.39, +5.64]
basic_py_check % cpu utilization +2.59 [+0.22, +4.97]
otel_to_otel_logs ingress throughput +0.27 [-0.19, +0.73]
process_agent_standard_check memory utilization +0.27 [+0.24, +0.30]
trace_agent_msgpack ingress throughput +0.03 [+0.02, +0.04]
trace_agent_json ingress throughput +0.02 [+0.00, +0.05]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
process_agent_real_time_mode memory utilization -0.07 [-0.10, -0.03]
file_tree memory utilization -0.10 [-0.15, -0.04]
process_agent_standard_check_with_stats memory utilization -0.17 [-0.20, -0.14]
tcp_syslog_to_blackhole ingress throughput -0.23 [-0.34, -0.12]
idle memory utilization -0.36 [-0.39, -0.32]
file_to_blackhole % cpu utilization -0.40 [-6.98, +6.17]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 23:03 pr-commenter[bot]

looks good to me at short term fix. But it could be good to make an upstream contribution to be able to list all the registered Analysers, so it is easier to deregister the one we don't need or don't know. it will prevent us to have similar issue in the future.

At first glance, I though TypeHistoryDockerfile was simply missing in the TypeConfigFiles list. However, this line made me think it was done on purpose.

0intro avatar Mar 14 '24 12:03 0intro

/merge

0intro avatar Mar 14 '24 12:03 0intro

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 14 '24 12:03 dd-devflow[bot]