datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[SBOM] Fix scanRequest type

Open 0intro opened this issue 1 year ago • 3 comments

What does this PR do?

This change fixes the following error:

2024-03-13 21:00:32 UTC | CORE | DEBUG | (pkg/collector/corechecks/sbom/processor.go:178 in processHostScanResult) | processing host scanresult: {invalid request type '*host.ScanRequest' for collector 'host' <nil> 2024-03-13 21:00:32.439957913 +0000 UTC m=+5.131362123 8.802µs <nil>}

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

0intro avatar Mar 13 '24 21:03 0intro

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30170906 --os-family=ubuntu

pr-commenter[bot] avatar Mar 13 '24 22:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 94d2570a-dbcc-45d6-847e-c441538cd3d5 Baseline: 2eec69afa8b069f52cf73512b8351d91ffa24f40 Comparison: 2386718b586498c310413fe71fe821ed24eea1d3

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.51 [-7.81, +4.78]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +0.71 [-1.82, +3.25]
pycheck_1000_100byte_tags % cpu utilization +0.63 [-4.27, +5.53]
otel_to_otel_logs ingress throughput +0.32 [-0.13, +0.78]
file_tree memory utilization +0.12 [+0.03, +0.21]
idle memory utilization +0.05 [+0.02, +0.09]
trace_agent_json ingress throughput +0.05 [+0.01, +0.09]
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.00, +0.05]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.00 [-0.02, +0.01]
process_agent_standard_check memory utilization -0.02 [-0.05, +0.01]
process_agent_real_time_mode memory utilization -0.03 [-0.06, +0.01]
process_agent_standard_check_with_stats memory utilization -0.31 [-0.34, -0.28]
uds_dogstatsd_to_api_cpu % cpu utilization -0.73 [-3.52, +2.07]
tcp_syslog_to_blackhole ingress throughput -0.78 [-0.86, -0.70]
file_to_blackhole % cpu utilization -1.51 [-7.81, +4.78]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 23:03 pr-commenter[bot]

Can we make this log an error log ? Perhaps e2e tests could be useful as well.

AliDatadog avatar Mar 13 '24 23:03 AliDatadog

Can we make this log an error log ? Perhaps e2e tests could be useful as well.

Done.

0intro avatar Mar 14 '24 07:03 0intro

/merge -c rebase

0intro avatar Mar 14 '24 12:03 0intro

/merge -c

0intro avatar Mar 15 '24 10:03 0intro

/merge -c rebase

0intro avatar Mar 15 '24 10:03 0intro

/merge

0intro avatar Mar 15 '24 11:03 0intro

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 15 '24 11:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is next! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 15 '24 12:03 dd-devflow[bot]