datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CWS] wip collection of allocation reductions

Open paulcacheux opened this issue 1 year ago • 2 comments
trafficstars

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

paulcacheux avatar Mar 13 '24 18:03 paulcacheux

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30617651 --os-family=ubuntu

pr-commenter[bot] avatar Mar 13 '24 21:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: d715c86f-77c4-430d-b182-04a1f8afa5f3 Baseline: 885f82b0008f463bdf15d9c2a3608aa855572435 Comparison: b4f88fd079dfb4755b786e24c1662335d405032a

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.77 [-5.62, +7.17]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +0.90 [+0.79, +1.02]
file_to_blackhole % cpu utilization +0.77 [-5.62, +7.17]
process_agent_real_time_mode memory utilization +0.28 [+0.24, +0.32]
process_agent_standard_check_with_stats memory utilization +0.14 [+0.11, +0.17]
trace_agent_json ingress throughput +0.03 [-0.00, +0.06]
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.22]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.03]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
otel_to_otel_logs ingress throughput -0.03 [-0.45, +0.40]
process_agent_standard_check memory utilization -0.08 [-0.12, -0.04]
uds_dogstatsd_to_api_cpu % cpu utilization -0.18 [-2.88, +2.52]
pycheck_1000_100byte_tags % cpu utilization -0.38 [-5.28, +4.51]
basic_py_check % cpu utilization -0.44 [-2.97, +2.08]
idle memory utilization -0.70 [-0.74, -0.66]
tcp_syslog_to_blackhole ingress throughput -0.93 [-1.02, -0.85]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 21:03 pr-commenter[bot]

/merge

paulcacheux avatar Mar 22 '24 09:03 paulcacheux

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 22 '24 09:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 3 builds ahead of this PR! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 22 '24 11:03 dd-devflow[bot]