datadog-agent
datadog-agent copied to clipboard
Add new sql obfuscation mode normalize_only
What does this PR do?
This PR adds new SQL obfuscation mode normalize_only to support normalizing SQL without obfuscating it.
This new mode is useful for customers who want to view unobfuscated SQL statements.
By default, ObfuscationMode is still set to obfuscate_and_normalize and every SQL statement is obfuscated and normalized.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: d38a41eb-c06f-4137-a1f9-53aef14c8448 Baseline: c4245acff2a1fb490ac262c5415f18bb83d443df Comparison: bd6875acfd01682a49059247ae53dc0b3e6ba33f
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.92 | [-5.65, +7.49] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +1.85 | [-0.40, +4.10] |
| ➖ | file_to_blackhole | % cpu utilization | +0.92 | [-5.65, +7.49] |
| ➖ | idle | memory utilization | +0.57 | [+0.52, +0.62] |
| ➖ | file_tree | memory utilization | +0.37 | [+0.29, +0.45] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.21 | [-2.68, +3.10] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.09 | [-0.31, +0.49] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.19, +0.22] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_json | ingress throughput | -0.01 | [-0.03, +0.01] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.02, -0.00] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.10 | [-0.14, -0.06] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.30 | [-0.40, -0.20] |
| ➖ | process_agent_standard_check | memory utilization | -0.33 | [-0.37, -0.28] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.55 | [-0.59, -0.50] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -2.28 | [-7.43, +2.88] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
@ajgajg1134 we have documented the meaning of different obfuscation mode in DBM integrations, where users can set different obfuscation_mode. (the new option normalize_only will be added once the PR is merged)
For example, https://github.com/DataDog/integrations-core/blob/master/postgres/assets/configuration/spec.yaml#L730-L739
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 3 builds ahead! (estimated merge in less than 27m)
Use /merge -c to cancel this operation!