datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

bump `google.golang.org/grpc` to v1.62.1 and `google.golang.org/protobuf` to v1.33.0

Open paulcacheux opened this issue 1 year ago • 4 comments
trafficstars

What does this PR do?

This PR bumps the grpc and protobuf dependencies to latest version

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

paulcacheux avatar Mar 13 '24 13:03 paulcacheux

Go Package Import Differences

Baseline: 46445e58c7ec11873f6b2c48d7398f2ac034a0e0 Comparison: 72586b3d3e015a9199582e1f5b67f64f2838f599

binaryosarchchange
agentlinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
agentlinuxarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
agentwindowsamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
agentwindows386
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
agentdarwinamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
agentdarwinarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
iot-agentlinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
iot-agentlinuxarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
heroku-agentlinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
cluster-agentlinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
cluster-agentlinuxarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
cluster-agent-cloudfoundrylinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
cluster-agent-cloudfoundrylinuxarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
dogstatsdlinuxamd64
+3, -1
-github.com/golang/protobuf/ptypes
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
dogstatsdlinuxarm64
+3, -1
-github.com/golang/protobuf/ptypes
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
process-agentlinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
process-agentlinuxarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
process-agentwindowsamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
process-agentdarwinamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
process-agentdarwinarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
heroku-process-agentlinuxamd64
+3, -1
-github.com/golang/protobuf/ptypes
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
security-agentlinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
security-agentlinuxarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
serverlesslinuxamd64
+3, -1
-github.com/golang/protobuf/ptypes
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
serverlesslinuxarm64
+3, -1
-github.com/golang/protobuf/ptypes
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
system-probelinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
system-probelinuxarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
system-probewindowsamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
trace-agentlinuxamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
trace-agentlinuxarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
trace-agentwindowsamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
trace-agentwindows386
+3, -1
-github.com/golang/protobuf/ptypes
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
trace-agentdarwinamd64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
trace-agentdarwinarm64
+3, -0
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb
heroku-trace-agentlinuxamd64
+3, -1
-github.com/golang/protobuf/ptypes
+google.golang.org/protobuf/internal/editiondefaults
+google.golang.org/protobuf/protoadapt
+google.golang.org/protobuf/types/gofeaturespb

cit-pr-commenter[bot] avatar Mar 13 '24 13:03 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 330a791a-08dd-4411-9d28-c2366a7a28e0 Baseline: 2b5bbee1959ca2ac23f0c519312bad431c40fc36 Comparison: cc5e8717477a4bcd57dc268d6b6e77c9b490ecf1

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.25 [-6.39, +6.89]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.21 [-1.82, +4.23]
process_agent_real_time_mode memory utilization +0.57 [+0.53, +0.61]
file_tree memory utilization +0.49 [+0.38, +0.60]
basic_py_check % cpu utilization +0.44 [-2.02, +2.90]
tcp_syslog_to_blackhole ingress throughput +0.32 [+0.21, +0.42]
file_to_blackhole % cpu utilization +0.25 [-6.39, +6.89]
process_agent_standard_check_with_stats memory utilization +0.14 [+0.11, +0.16]
otel_to_otel_logs ingress throughput +0.10 [-0.34, +0.54]
idle memory utilization +0.03 [-0.01, +0.06]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.00 [-0.02, +0.01]
process_agent_standard_check memory utilization -0.02 [-0.05, +0.02]
trace_agent_json ingress throughput -0.04 [-0.08, -0.01]
pycheck_1000_100byte_tags % cpu utilization -0.80 [-6.08, +4.49]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 15:03 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30061536 --os-family=ubuntu

pr-commenter[bot] avatar Mar 13 '24 21:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: bff25b3b-a7dc-4c70-a618-5a8677d1e817 Baseline: 46445e58c7ec11873f6b2c48d7398f2ac034a0e0 Comparison: 72586b3d3e015a9199582e1f5b67f64f2838f599

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -2.20 [-8.67, +4.26]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +2.12 [-0.87, +5.11]
process_agent_standard_check memory utilization +0.68 [+0.63, +0.72]
trace_agent_json ingress throughput +0.02 [-0.00, +0.04]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.02 [-0.22, +0.19]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
otel_to_otel_logs ingress throughput -0.29 [-0.70, +0.13]
process_agent_real_time_mode memory utilization -0.36 [-0.40, -0.32]
process_agent_standard_check_with_stats memory utilization -0.45 [-0.49, -0.41]
pycheck_1000_100byte_tags % cpu utilization -1.03 [-6.23, +4.17]
idle memory utilization -1.04 [-1.08, -1.00]
file_tree memory utilization -1.21 [-1.32, -1.09]
tcp_syslog_to_blackhole ingress throughput -1.27 [-1.39, -1.16]
file_to_blackhole % cpu utilization -2.20 [-8.67, +4.26]
basic_py_check % cpu utilization -4.19 [-6.49, -1.89]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 21:03 pr-commenter[bot]

/merge

paulcacheux avatar Mar 14 '24 12:03 paulcacheux

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 14 '24 12:03 dd-devflow[bot]