datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

feat(ci): Add coverage run for invoke task and set them aside go tests

Open chouetz opened this issue 1 year ago • 6 comments
trafficstars

What does this PR do?

Run invoke unit tests in dedicated jobs. Will add coverage afterwards

Motivation

Invoke tasks are a different workload in the datadog-agent repo. Their UT can run independently and having a dedicated workflow (and coverage) would give rapid feedback for devx team when touching those

Additional Notes

I will probably create a side workflow for kitchen.invoke-unit-tests We could easily use coverage-scope action to enforce a gating on coverage for invoke tasks

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

chouetz avatar Mar 13 '24 08:03 chouetz

/merge

chouetz avatar Mar 15 '24 16:03 chouetz

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 15 '24 16:03 dd-devflow[bot]

[Fast Unit Tests Report]

On pipeline 31909260 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30232297 --os-family=ubuntu

pr-commenter[bot] avatar Mar 15 '24 17:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 1502639f-41ad-4ecb-a056-f897b2b30bc0 Baseline: 658b5e08174d2dd20f22e0350fae735aa6684f67 Comparison: 5e7513298189974c62713f87621815fd0a713d7e

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.89 [-5.80, +4.02]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +4.30 [+1.67, +6.93]
pycheck_1000_100byte_tags % cpu utilization +1.60 [-3.38, +6.57]
tcp_syslog_to_blackhole ingress throughput +0.49 [+0.39, +0.58]
file_tree memory utilization +0.34 [+0.26, +0.41]
process_agent_standard_check_with_stats memory utilization +0.21 [+0.16, +0.27]
otel_to_otel_logs ingress throughput +0.09 [-0.32, +0.51]
tcp_dd_logs_filter_exclude ingress throughput +0.04 [+0.00, +0.07]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.02]
trace_agent_json ingress throughput +0.00 [-0.02, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
process_agent_real_time_mode memory utilization -0.25 [-0.29, -0.21]
idle memory utilization -0.35 [-0.39, -0.31]
process_agent_standard_check memory utilization -0.65 [-0.71, -0.59]
file_to_blackhole % cpu utilization -0.89 [-5.80, +4.02]
uds_dogstatsd_to_api_cpu % cpu utilization -1.45 [-4.43, +1.54]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 15 '24 17:03 pr-commenter[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Mar 15 '24 20:03 dd-devflow[bot]

/merge

chouetz avatar Apr 12 '24 12:04 chouetz

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 47m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Apr 12 '24 12:04 dd-devflow[bot]