Add tests on notify jobs to prevent failures

[chouetz]

trafficstars

What does this PR do?

Add new tests on notify jobs to validate their execution.

Motivation

Pipeline stability

Additional Notes

This PR contains a first commit which is an aside change to set datadog-agent as default repo when calling github/gitlab API. Can be reviewed separately

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 99f244a7-4088-4698-8aff-d159813fd4ba Baseline: d6a7e7927b96c58b1ca37d5a45453a1a457e3958 Comparison: 6f17e06883ae5e9be1504d9add09e8f5c2de8155

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.36	[-6.90, +6.18]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	basic_py_check	% cpu utilization	+1.36	[-0.97, +3.69]
➖	otel_to_otel_logs	ingress throughput	+0.53	[-0.09, +1.16]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.32	[+0.27, +0.37]
➖	process_agent_standard_check_with_stats	memory utilization	+0.22	[+0.19, +0.26]
➖	trace_agent_json	ingress throughput	+0.02	[-0.01, +0.05]
➖	trace_agent_msgpack	ingress throughput	+0.01	[+0.00, +0.02]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	process_agent_real_time_mode	memory utilization	-0.04	[-0.08, -0.01]
➖	idle	memory utilization	-0.10	[-0.14, -0.06]
➖	file_to_blackhole	% cpu utilization	-0.36	[-6.90, +6.18]
➖	file_tree	memory utilization	-0.50	[-0.58, -0.42]
➖	process_agent_standard_check	memory utilization	-0.60	[-0.63, -0.57]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.00	[-2.44, +0.43]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30048153 --os-family=ubuntu

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 53b1e20f-4118-47ae-a2ac-a2c87825e6f7 Baseline: e5af1baab0d7b326816c97434ab0c0aa26adf4b6 Comparison: 56c12344123f558e52c92d352d13a7db69813979

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.52	[-6.06, +7.11]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.27	[-0.67, +5.22]
➖	file_to_blackhole	% cpu utilization	+0.52	[-6.06, +7.11]
➖	pycheck_1000_100byte_tags	% cpu utilization	+0.22	[-4.98, +5.42]
➖	process_agent_standard_check	memory utilization	+0.15	[+0.12, +0.18]
➖	process_agent_real_time_mode	memory utilization	+0.14	[+0.10, +0.17]
➖	idle	memory utilization	+0.08	[+0.05, +0.12]
➖	otel_to_otel_logs	ingress throughput	+0.04	[-0.37, +0.45]
➖	trace_agent_msgpack	ingress throughput	-0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.22, +0.20]
➖	trace_agent_json	ingress throughput	-0.02	[-0.05, +0.01]
➖	process_agent_standard_check_with_stats	memory utilization	-0.09	[-0.12, -0.07]
➖	file_tree	memory utilization	-0.10	[-0.16, -0.04]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.50	[-0.61, -0.40]
➖	basic_py_check	% cpu utilization	-0.89	[-3.24, +1.46]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[chouetz]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

[chouetz]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Added to the queue.

This build is next! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!