datadog-agent
datadog-agent copied to clipboard
[CWS] Remove UID / GID from cws instrumentation security context
What does this PR do?
This PR removes the UID / GID from the cws instrumentation security context as it turns out it would break OpenShift deployments. However, we're keeping the UID definition in the cws-instrumentation Dockerfile.
Motivation
This patch will fix the runAsNonRoot bug described here while ensuring we keep OpenShift support.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 22bb996a-2dd8-4ea5-8b4c-078192fad411 Baseline: c6b52ff2d46479df800861fe1d2991affc430d1a Comparison: d21e47532aede7d2561190be14e87c2fbb83767f
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.01 | [-6.56, +6.58] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +1.30 | [-1.02, +3.62] |
| ➖ | file_tree | memory utilization | +0.38 | [+0.33, +0.44] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.18 | [-0.27, +0.62] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.12 | [+0.03, +0.21] |
| ➖ | trace_agent_json | ingress throughput | +0.03 | [+0.00, +0.06] |
| ➖ | file_to_blackhole | % cpu utilization | +0.01 | [-6.56, +6.58] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.01 | [-0.01, +0.02] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.22, +0.19] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.03 | [-0.06, +0.01] |
| ➖ | idle | memory utilization | -0.07 | [-0.11, -0.04] |
| ➖ | process_agent_standard_check | memory utilization | -0.12 | [-0.15, -0.09] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.47 | [-0.50, -0.44] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.87 | [-3.76, +2.02] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.20 | [-6.41, +4.01] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:steam_locomotive: MergeQueue
Added to the queue.
There are 2 builds ahead of this PR! (estimated merge in less than 26m)
Use /merge -c to cancel this operation!