datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

fix serverless integration tests artifact names

Open paulcacheux opened this issue 1 year ago • 1 comments
trafficstars

What does this PR do?

With the merge of https://github.com/DataDog/datadog-agent/pull/21613, the new upload artifact does not support pushing to a common zip archive. This PR fixes the issue by including the arch and the suite in the name to make it unique.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

paulcacheux avatar Mar 11 '24 22:03 paulcacheux

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: f753c7b6-95a8-410d-9bda-f7835d22a10f Baseline: 559554ac4c9fcc7147fea741ad8d2574bdfef5e1 Comparison: 4ebac97eff85d042abf2a3995c2ca662807cd19b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.29 [-6.30, +6.89]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +2.36 [-0.03, +4.75]
otel_to_otel_logs ingress throughput +0.34 [-0.31, +0.98]
file_to_blackhole % cpu utilization +0.29 [-6.30, +6.89]
process_agent_standard_check memory utilization +0.13 [+0.10, +0.16]
process_agent_real_time_mode memory utilization +0.03 [-0.00, +0.07]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.06, +0.06]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.05, +0.05]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.05 [-0.08, -0.01]
tcp_syslog_to_blackhole ingress throughput -0.14 [-0.22, -0.05]
pycheck_1000_100byte_tags % cpu utilization -0.28 [-5.52, +4.96]
process_agent_standard_check_with_stats memory utilization -0.33 [-0.36, -0.30]
file_tree memory utilization -0.58 [-0.63, -0.52]
idle memory utilization -0.61 [-0.64, -0.57]
uds_dogstatsd_to_api_cpu % cpu utilization -1.82 [-4.84, +1.20]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 11 '24 23:03 pr-commenter[bot]

/merge

paulcacheux avatar Mar 12 '24 06:03 paulcacheux

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 12 '24 06:03 dd-devflow[bot]

:warning: MergeQueue

This pull request was closed.

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Mar 12 '24 06:03 dd-devflow[bot]

/merge

paulcacheux avatar Mar 12 '24 06:03 paulcacheux

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 12 '24 06:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 12 '24 07:03 dd-devflow[bot]