datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Add test artifact to gitignore

Open pgimalac opened this issue 1 year ago • 1 comments

What does this PR do?

Add a test-generated file to gitignore.

Motivation

Running inv test will create that file and I have to delete it to not accidentally add it to git.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pgimalac avatar Mar 11 '24 17:03 pgimalac

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 659f9684-1bad-4ddc-9f21-cfbf64b56975 Baseline: 8c5ec0f072ca053b31bc91d38db55d46d256a8e4 Comparison: a4673de3d1851c0b5c5f9928485a823d5c16f2f6

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.49 [-6.11, +7.09]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
process_agent_real_time_mode memory utilization +1.83 [+1.79, +1.87]
basic_py_check % cpu utilization +1.36 [-0.84, +3.55]
process_agent_standard_check memory utilization +0.85 [+0.81, +0.89]
file_to_blackhole % cpu utilization +0.49 [-6.11, +7.09]
process_agent_standard_check_with_stats memory utilization +0.09 [+0.05, +0.14]
tcp_syslog_to_blackhole ingress throughput +0.01 [-0.04, +0.06]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.01 [-0.03, -0.00]
file_tree memory utilization -0.01 [-0.13, +0.10]
trace_agent_json ingress throughput -0.02 [-0.05, +0.02]
uds_dogstatsd_to_api_cpu % cpu utilization -0.26 [-1.72, +1.20]
otel_to_otel_logs ingress throughput -1.43 [-2.09, -0.77]
idle memory utilization -1.90 [-1.94, -1.85]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 11 '24 19:03 pr-commenter[bot]

/merge

pgimalac avatar Mar 12 '24 16:03 pgimalac

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 12 '24 16:03 dd-devflow[bot]