datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

remove process_raw_message warning for windowsevents tailer

Open clarkb7 opened this issue 11 months ago • 1 comments

What does this PR do?

removes the warning message about process_raw_message behavior/deprecation from the windowsevents tailer.

Motivation

There are filtering rules used by customers that the new behavior does not currently support. for example, EventID is a structured field that is not included in the eventlog rendered message.

       log_processing_rules:
       - type: include_at_match
         name: relevant_security_events
         pattern: '"EventID":(?:{"value":)?"(1102|4624|4625)"'

So we're removing the warning until there is support for actions a customer can take.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

clarkb7 avatar Mar 11 '24 16:03 clarkb7

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 7f5f1c37-0555-4a2b-803a-5a5762fd0f2a Baseline: e4ef17285dd2e0242d6864bd1ebe96eb90584f71 Comparison: 4092820a1b0957183bb5a9424e6f38e543d94d52

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +2.91 [-3.94, +9.77]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +2.91 [-3.94, +9.77]
otel_to_otel_logs ingress throughput +1.66 [+1.03, +2.29]
uds_dogstatsd_to_api_cpu % cpu utilization +0.75 [-0.70, +2.20]
tcp_syslog_to_blackhole ingress throughput +0.44 [+0.39, +0.49]
process_agent_standard_check_with_stats memory utilization +0.23 [+0.19, +0.28]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.02 [-0.03, +0.00]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
process_agent_standard_check memory utilization -0.16 [-0.20, -0.12]
file_tree memory utilization -0.23 [-0.35, -0.11]
idle memory utilization -0.25 [-0.30, -0.21]
process_agent_real_time_mode memory utilization -0.51 [-0.55, -0.46]
basic_py_check % cpu utilization -1.30 [-3.54, +0.94]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 11 '24 17:03 pr-commenter[bot]

/merge

clarkb7 avatar Mar 12 '24 17:03 clarkb7

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 12 '24 17:03 dd-devflow[bot]