[CONTINT-3921] Tagger component: remove Start/Stop method

[zhuminyi]

trafficstars

What does this PR do?

Start/Stop methods are converted to an internal function in favour of managing by fx.Lifecyle

Motivation

Usually, Start and Stop methods should not be in the component interface too as it should be handled using Lifecycle hooks.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Tag should work in agent without any changes. agent workload-list/ agent flare -l: no crash agent tagger-list: tags are reported correctly

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 4694b314-a6df-4128-8e7a-aafcf0fc6c73 Baseline: 5a503085a6bcb43a5faca9f3d8dafc9f5e9e077c Comparison: 4be3195cdcb312632137cf5b19a55de0f7335e22

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-1.04	[-7.56, +5.47]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	basic_py_check	% cpu utilization	+1.26	[-1.14, +3.65]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.40	[-1.05, +1.85]
➖	process_agent_standard_check	memory utilization	+0.30	[+0.26, +0.34]
➖	otel_to_otel_logs	ingress throughput	+0.27	[-0.37, +0.92]
➖	process_agent_standard_check_with_stats	memory utilization	+0.26	[+0.21, +0.31]
➖	idle	memory utilization	+0.22	[+0.18, +0.26]
➖	file_tree	memory utilization	+0.14	[+0.04, +0.24]
➖	trace_agent_msgpack	ingress throughput	+0.01	[-0.00, +0.02]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.00	[-0.05, +0.04]
➖	process_agent_real_time_mode	memory utilization	-0.20	[-0.24, -0.16]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.20	[-0.26, -0.15]
➖	file_to_blackhole	% cpu utilization	-1.04	[-7.56, +5.47]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30473427 --os-family=ubuntu

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: cbb79a66-f77b-4cea-ac5a-deaaa89092d1 Baseline: f8f4cb515da4b1fb7a9e7f0315d8db816510b607 Comparison: 3d01af61ae4c7ca35034c4d058725313402b81f7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.56	[-5.81, +6.92]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	idle	memory utilization	+0.62	[+0.58, +0.66]
➖	file_to_blackhole	% cpu utilization	+0.56	[-5.81, +6.92]
➖	process_agent_real_time_mode	memory utilization	+0.40	[+0.36, +0.43]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.28	[+0.20, +0.36]
➖	process_agent_standard_check	memory utilization	+0.19	[+0.15, +0.23]
➖	otel_to_otel_logs	ingress throughput	+0.15	[-0.30, +0.61]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.11	[-2.62, +2.84]
➖	file_tree	memory utilization	+0.09	[-0.00, +0.19]
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.19, +0.22]
➖	trace_agent_json	ingress throughput	+0.01	[-0.02, +0.04]
➖	trace_agent_msgpack	ingress throughput	-0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.02	[-0.04, +0.01]
➖	process_agent_standard_check_with_stats	memory utilization	-0.14	[-0.19, -0.09]
➖	basic_py_check	% cpu utilization	-0.43	[-2.75, +1.88]
➖	pycheck_1000_100byte_tags	% cpu utilization	-2.30	[-7.13, +2.53]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[zhuminyi]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!