trafficstars

What does this PR do?

This PR bumps gopkg.in/DataDog/dd-trace-go.v1 to v1.61.0, the latest at this time. Small reminder that, except for serverless usage, this lib is mostly used to drive the internal profiling feature. A few out of ordinary changes required:

https://github.com/DataDog/dd-trace-go/pull/2368 (including in v1.61.0) changes the default context propagation order resulting in the changes to TestExtractorExtract
with https://github.com/DataDog/dd-trace-go/releases/tag/v1.59.0, ASM is kind of enabled by default, at least from a build perspective (to allow it to be enabled remotely through remote config). Since we do not need/want this on the agent I added the datadog.no_waf build tag to all agent processes to opt out of the ASM build requirements. Serverless on the other hand needs this (and its tests as well).

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Mar 11 '24 13:03 paulcacheux

Go Package Import Differences

Baseline: 42955c0c634aad65d8261fed1f36ca5b41946c6f Comparison: eb9aa9def5a4b139056ed05d230f9befcac6d03e

binary	os	arch	change
agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	windows	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	windows	386	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	darwin	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	darwin	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
iot-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
iot-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
heroku-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
cluster-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
cluster-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
cluster-agent-cloudfoundry	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
cluster-agent-cloudfoundry	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
dogstatsd	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
dogstatsd	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	windows	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	darwin	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	darwin	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
heroku-process-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
security-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
security-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
serverless	linux	amd64	+5, -0 +github.com/DataDog/go-libddwaf/v2/internal/log +gopkg.in/DataDog/dd-trace-go.v1/internal/appsec/config +gopkg.in/DataDog/dd-trace-go.v1/internal/appsec/dyngo +gopkg.in/DataDog/dd-trace-go.v1/internal/appsec/emitter/sharedsec +gopkg.in/DataDog/dd-trace-go.v1/internal/appsec/listener
serverless	linux	arm64	+4, -4 -github.com/DataDog/go-libddwaf/v2/internal/lib -github.com/ebitengine/purego -github.com/ebitengine/purego/internal/fakecgo -github.com/ebitengine/purego/internal/strings +gopkg.in/DataDog/dd-trace-go.v1/internal/appsec/config +gopkg.in/DataDog/dd-trace-go.v1/internal/appsec/dyngo +gopkg.in/DataDog/dd-trace-go.v1/internal/appsec/emitter/sharedsec +gopkg.in/DataDog/dd-trace-go.v1/internal/appsec/listener
system-probe	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
system-probe	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
system-probe	windows	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	windows	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	windows	386	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	darwin	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	darwin	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
heroku-trace-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig

Mar 11 '24 13:03 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 21bb2c6c-f28c-4a77-bba1-33c8c9e5ef52 Baseline: 42955c0c634aad65d8261fed1f36ca5b41946c6f Comparison: eb9aa9def5a4b139056ed05d230f9befcac6d03e

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.21	[-6.34, +6.76]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_tree	memory utilization	+3.23	[+3.14, +3.32]
➖	tcp_syslog_to_blackhole	ingress throughput	+1.80	[+1.70, +1.90]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.83	[-2.17, +3.83]
➖	process_agent_real_time_mode	memory utilization	+0.62	[+0.57, +0.67]
➖	file_to_blackhole	% cpu utilization	+0.21	[-6.34, +6.76]
➖	process_agent_standard_check_with_stats	memory utilization	+0.04	[-0.01, +0.08]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.06, +0.06]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.05, +0.05]
➖	trace_agent_msgpack	ingress throughput	-0.00	[-0.01, +0.01]
➖	trace_agent_json	ingress throughput	-0.01	[-0.04, +0.02]
➖	otel_to_otel_logs	ingress throughput	-0.10	[-0.73, +0.53]
➖	process_agent_standard_check	memory utilization	-0.36	[-0.41, -0.31]
➖	idle	memory utilization	-0.60	[-0.66, -0.55]
➖	pycheck_1000_100byte_tags	% cpu utilization	-1.56	[-6.73, +3.60]
➖	basic_py_check	% cpu utilization	-1.67	[-3.93, +0.58]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Mar 11 '24 14:03 pr-commenter[bot]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between f9ae7f4b842f83b23b2dfe3f15d31f9e6b12e857 and 98f7c84cf1959c716a602f2a917fe80093cb08b3.

tl;dr

Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.
The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            83.60µ ± 5%   84.05µ ± 9%       ~ (p=0.631 n=10)
api-gateway-kong-appsec.json                       66.02µ ± 1%   66.01µ ± 2%       ~ (p=0.853 n=10)
api-gateway-kong.json                              63.67µ ± 2%   64.28µ ± 1%       ~ (p=0.315 n=10)
api-gateway-non-proxy-async.json                   101.9µ ± 1%   101.8µ ± 2%       ~ (p=0.796 n=10)
api-gateway-non-proxy.json                         102.1µ ± 1%   101.9µ ± 2%       ~ (p=0.853 n=10)
api-gateway-websocket-connect.json                 67.68µ ± 1%   68.12µ ± 1%       ~ (p=0.315 n=10)
api-gateway-websocket-default.json                 60.82µ ± 1%   61.48µ ± 1%  +1.08% (p=0.011 n=10)
api-gateway-websocket-disconnect.json              61.13µ ± 1%   61.17µ ± 1%       ~ (p=0.912 n=10)
api-gateway.json                                   113.0µ ± 1%   111.8µ ± 1%       ~ (p=0.089 n=10)
application-load-balancer.json                     61.93µ ± 1%   60.89µ ± 2%       ~ (p=0.086 n=10)
cloudfront.json                                    47.39µ ± 3%   46.16µ ± 1%  -2.61% (p=0.000 n=10)
cloudwatch-events.json                             37.62µ ± 1%   37.53µ ± 1%       ~ (p=0.481 n=10)
cloudwatch-logs.json                               64.15µ ± 1%   64.85µ ± 3%  +1.09% (p=0.001 n=10)
custom.json                                        30.09µ ± 2%   29.61µ ± 2%  -1.61% (p=0.035 n=10)
dynamodb.json                                      93.31µ ± 1%   91.22µ ± 2%  -2.25% (p=0.001 n=10)
empty.json                                         28.03µ ± 1%   28.02µ ± 4%       ~ (p=0.684 n=10)
eventbridge-custom.json                            41.90µ ± 2%   41.06µ ± 2%       ~ (p=0.075 n=10)
http-api.json                                      72.03µ ± 2%   71.91µ ± 1%       ~ (p=0.631 n=10)
kinesis-batch.json                                 71.25µ ± 2%   70.03µ ± 1%  -1.71% (p=0.043 n=10)
kinesis.json                                       53.69µ ± 2%   52.71µ ± 2%  -1.82% (p=0.011 n=10)
s3.json                                            58.94µ ± 3%   58.06µ ± 2%  -1.51% (p=0.015 n=10)
sns-batch.json                                     90.29µ ± 2%   89.39µ ± 2%       ~ (p=0.393 n=10)
sns.json                                           64.90µ ± 2%   63.88µ ± 2%       ~ (p=0.105 n=10)
snssqs.json                                        107.3µ ± 1%   109.7µ ± 2%  +2.19% (p=0.002 n=10)
snssqs_no_dd_context.json                          99.17µ ± 2%   98.27µ ± 2%  -0.91% (p=0.035 n=10)
sqs-aws-header.json                                54.64µ ± 2%   53.65µ ± 2%  -1.81% (p=0.001 n=10)
sqs-batch.json                                     93.92µ ± 1%   92.60µ ± 2%       ~ (p=0.165 n=10)
sqs.json                                           68.24µ ± 2%   66.81µ ± 2%  -2.09% (p=0.015 n=10)
sqs_no_dd_context.json                             61.37µ ± 2%   60.43µ ± 2%  -1.53% (p=0.011 n=10)
geomean                                            65.77µ        65.30µ       -0.72%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.11Ki ± 0%   37.11Ki ± 0%       ~ (p=0.839 n=10)
api-gateway-kong-appsec.json                      26.77Ki ± 0%   26.78Ki ± 0%       ~ (p=0.754 n=10)
api-gateway-kong.json                             24.27Ki ± 0%   24.27Ki ± 0%       ~ (p=0.754 n=10)
api-gateway-non-proxy-async.json                  47.91Ki ± 0%   47.91Ki ± 0%       ~ (p=0.724 n=10)
api-gateway-non-proxy.json                        47.11Ki ± 0%   47.12Ki ± 0%       ~ (p=0.698 n=10)
api-gateway-websocket-connect.json                25.35Ki ± 0%   25.35Ki ± 0%       ~ (p=0.446 n=10)
api-gateway-websocket-default.json                21.25Ki ± 0%   21.25Ki ± 0%       ~ (p=0.956 n=10)
api-gateway-websocket-disconnect.json             21.03Ki ± 0%   21.03Ki ± 0%       ~ (p=0.781 n=10)
api-gateway.json                                  49.42Ki ± 0%   49.42Ki ± 0%       ~ (p=0.540 n=10)
application-load-balancer.json                    22.22Ki ± 0%   22.21Ki ± 0%       ~ (p=0.239 n=10)
cloudfront.json                                   17.54Ki ± 0%   17.54Ki ± 0%       ~ (p=0.424 n=10)
cloudwatch-events.json                            11.60Ki ± 0%   11.60Ki ± 0%       ~ (p=0.781 n=10)
cloudwatch-logs.json                              53.26Ki ± 0%   53.26Ki ± 0%       ~ (p=0.183 n=10)
custom.json                                       9.624Ki ± 0%   9.625Ki ± 0%       ~ (p=0.616 n=10)
dynamodb.json                                     40.56Ki ± 0%   40.55Ki ± 0%       ~ (p=0.617 n=10)
empty.json                                        9.171Ki ± 0%   9.178Ki ± 0%       ~ (p=0.541 n=10)
eventbridge-custom.json                           13.31Ki ± 0%   13.30Ki ± 0%       ~ (p=0.971 n=10)
http-api.json                                     23.60Ki ± 0%   23.59Ki ± 0%       ~ (p=0.725 n=10)
kinesis-batch.json                                26.91Ki ± 0%   26.89Ki ± 0%       ~ (p=0.137 n=10)
kinesis.json                                      17.70Ki ± 0%   17.70Ki ± 0%       ~ (p=0.565 n=10)
s3.json                                           20.22Ki ± 0%   20.23Ki ± 0%       ~ (p=0.754 n=10)
sns-batch.json                                    38.52Ki ± 0%   38.55Ki ± 0%       ~ (p=0.481 n=10)
sns.json                                          23.86Ki ± 0%   23.89Ki ± 0%       ~ (p=0.079 n=10)
snssqs.json                                       49.52Ki ± 0%   50.51Ki ± 0%  +2.00% (p=0.000 n=10)
snssqs_no_dd_context.json                         44.70Ki ± 0%   44.68Ki ± 0%       ~ (p=0.481 n=10)
sqs-aws-header.json                               18.74Ki ± 0%   18.75Ki ± 0%       ~ (p=0.631 n=10)
sqs-batch.json                                    41.52Ki ± 0%   41.51Ki ± 0%       ~ (p=0.754 n=10)
sqs.json                                          25.39Ki ± 1%   25.42Ki ± 0%       ~ (p=0.739 n=10)
sqs_no_dd_context.json                            20.62Ki ± 0%   20.61Ki ± 0%       ~ (p=0.869 n=10)
geomean                                           25.56Ki        25.58Ki       +0.08%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             628.0 ± 0%   628.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong-appsec.json                        487.0 ± 0%   487.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               465.0 ± 0%   465.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    724.0 ± 0%   724.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-non-proxy.json                          715.0 ± 0%   715.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-connect.json                  452.0 ± 0%   452.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  378.0 ± 0%   378.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json               368.0 ± 0%   368.0 ± 0%       ~ (p=1.000 n=10)
api-gateway.json                                    789.0 ± 0%   789.0 ± 0%       ~ (p=1.000 n=10) ¹
application-load-balancer.json                      350.0 ± 0%   350.0 ± 0%       ~ (p=1.000 n=10)
cloudfront.json                                     282.0 ± 0%   282.0 ± 0%       ~ (p=1.000 n=10)
cloudwatch-events.json                              219.0 ± 0%   219.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-logs.json                                214.0 ± 0%   214.0 ± 0%       ~ (p=1.000 n=10) ¹
custom.json                                         167.0 ± 0%   167.0 ± 0%       ~ (p=1.000 n=10)
dynamodb.json                                       587.0 ± 0%   587.0 ± 0%       ~ (p=1.000 n=10)
empty.json                                          158.0 ± 0%   158.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-custom.json                             252.0 ± 0%   252.0 ± 0%       ~ (p=0.303 n=10)
http-api.json                                       431.0 ± 0%   431.0 ± 0%       ~ (p=1.000 n=10)
kinesis-batch.json                                  389.0 ± 0%   389.0 ± 0%       ~ (p=1.000 n=10)
kinesis.json                                        284.0 ± 0%   284.0 ± 0%       ~ (p=1.000 n=10)
s3.json                                             356.0 ± 0%   356.0 ± 0%       ~ (p=1.000 n=10)
sns-batch.json                                      453.0 ± 0%   453.5 ± 0%       ~ (p=0.553 n=10)
sns.json                                            321.0 ± 0%   322.0 ± 0%       ~ (p=0.147 n=10)
snssqs.json                                         423.0 ± 0%   444.0 ± 0%  +4.96% (p=0.000 n=10)
snssqs_no_dd_context.json                           398.0 ± 0%   398.0 ± 0%       ~ (p=0.700 n=10)
sqs-aws-header.json                                 272.0 ± 0%   272.0 ± 0%       ~ (p=0.700 n=10)
sqs-batch.json                                      502.0 ± 0%   501.5 ± 0%       ~ (p=0.657 n=10)
sqs.json                                            348.5 ± 1%   349.0 ± 1%       ~ (p=0.766 n=10)
sqs_no_dd_context.json                              324.0 ± 1%   324.0 ± 0%       ~ (p=0.891 n=10)
geomean                                             374.4        375.0       +0.18%
¹ all samples are equal

Mar 13 '24 16:03 github-actions[bot]

/merge

Mar 13 '24 16:03 paulcacheux

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

Mar 13 '24 16:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is next! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!

Mar 13 '24 17:03 dd-devflow[bot]

datadog-agent
datadog-agent copied to clipboard

bump `gopkg.in/DataDog/dd-trace-go.v1` to v1.61.0

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Go Package Import Differences

Bloop Bleep... Dogbot Here

Regression Detector Results

No significant changes in experiment optimization goals

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

Serverless Benchmark Results

datadog-agent datadog-agent copied to clipboard

bump `gopkg.in/DataDog/dd-trace-go.v1` to v1.61.0

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Go Package Import Differences

Bloop Bleep... Dogbot Here

Regression Detector Results

No significant changes in experiment optimization goals

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

Serverless Benchmark Results

datadog-agent
datadog-agent copied to clipboard