usm: kafka: Migrate encoding to use gostreamer
What does this PR do?
Migrating the kafka encoding to use inline encoding and protobuf marshaling by using the gostreamer interface. This PR matches PR #19533 for http2, and #18408 for http.
Motivation
gostreamer performance is much better than the old implementation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 8bb8ad61-0464-4d8a-b906-d0a143253b3b Baseline: 9ec655641faf224d7a70e5e25bc91f5e485b9293 Comparison: 35ba9ec5a4fb5d203af73f39d28d0a3e41adde86
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.61 | [-5.99, +7.20] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.01 | [-0.43, +2.46] |
| ➖ | file_to_blackhole | % cpu utilization | +0.61 | [-5.99, +7.20] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.54 | [+0.51, +0.58] |
| ➖ | idle | memory utilization | +0.18 | [+0.14, +0.21] |
| ➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.03] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.06 | [-0.09, -0.03] |
| ➖ | process_agent_standard_check | memory utilization | -0.08 | [-0.11, -0.05] |
| ➖ | file_tree | memory utilization | -0.18 | [-0.25, -0.11] |
| ➖ | basic_py_check | % cpu utilization | -0.23 | [-2.52, +2.06] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.51 | [-0.56, -0.46] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.82 | [-1.45, -0.18] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 4 builds ahead! (estimated merge in less than 27m)
Use /merge -c to cancel this operation!