apply log limit on rc client

[guyarb]

What does this PR do?

• Moves log limit to a shared package
• Limits RC spamming log message

Motivation

Limit a spamming log in case of an error

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 8651c546-62d5-4655-89cd-10696bbf40ed Baseline: 9ec655641faf224d7a70e5e25bc91f5e485b9293 Comparison: e179ae607d76033e60b589cd543c380c5a241b79

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+1.00	[-5.57, +7.57]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	basic_py_check	% cpu utilization	+1.36	[-0.82, +3.54]
➖	file_to_blackhole	% cpu utilization	+1.00	[-5.57, +7.57]
➖	file_tree	memory utilization	+0.25	[+0.18, +0.33]
➖	otel_to_otel_logs	ingress throughput	+0.03	[-0.60, +0.67]
➖	trace_agent_msgpack	ingress throughput	+0.03	[+0.02, +0.05]
➖	trace_agent_json	ingress throughput	+0.01	[-0.03, +0.05]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	process_agent_real_time_mode	memory utilization	-0.00	[-0.04, +0.03]
➖	process_agent_standard_check_with_stats	memory utilization	-0.18	[-0.21, -0.15]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.22	[-0.27, -0.16]
➖	idle	memory utilization	-0.42	[-0.45, -0.38]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.43	[-1.88, +1.03]
➖	process_agent_standard_check	memory utilization	-0.47	[-0.50, -0.44]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[guyarb]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 6 builds ahead! (estimated merge in less than 54m)

Use /merge -c to cancel this operation!