[CWS] move `pkg/security/secl` back to a `go 1.21` go mod line

[paulcacheux]

trafficstars

What does this PR do?

pkg/security/secl is still imported by packages defining their go mod line as go 1.21 resulting in dirty files (dd-go..). As is it means we need to revert pkg/security/secl/go.mod to go 1.21.

This PR also updates the rest of the go update mechanism to transparently handle this kind of legacy go mod requirement.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 44285b30-4f0c-403f-a1b4-18f229745b42 Baseline: 9ec655641faf224d7a70e5e25bc91f5e485b9293 Comparison: 80cf2cbc4dc1e097de243b40e932b4f1030d088a

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.56	[-6.04, +7.16]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.56	[-6.04, +7.16]
➖	process_agent_standard_check_with_stats	memory utilization	+0.28	[+0.25, +0.31]
➖	trace_agent_msgpack	ingress throughput	+0.02	[+0.01, +0.03]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.01	[-0.04, +0.02]
➖	file_tree	memory utilization	-0.23	[-0.31, -0.15]
➖	process_agent_real_time_mode	memory utilization	-0.29	[-0.32, -0.25]
➖	otel_to_otel_logs	ingress throughput	-0.36	[-0.98, +0.27]
➖	process_agent_standard_check	memory utilization	-0.39	[-0.42, -0.36]
➖	idle	memory utilization	-0.39	[-0.42, -0.35]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.43	[-0.48, -0.37]
➖	basic_py_check	% cpu utilization	-0.62	[-2.82, +1.59]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.74	[-2.19, +0.71]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[paulcacheux]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!