Add Windows MSI E2E test for custom install paths

[clarkb7]

What does this PR do?

Add Windows MSI E2E test for custom install paths

Adds an AgentInstallPath parameter to the E2E AgentClient

Motivation

https://datadoghq.atlassian.net/browse/WINA-507

Additional Notes

seems like after https://github.com/DataDog/test-infra-definitions/pull/675 we might be able to include the agent install path in the agent.HostAgentOutput, making it available for when components.RemoteHostAgent is created.

marked draft since this PR is stacked on pending PRs

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 1382db6e-ac36-4c54-8c09-a27c9feb83af Baseline: c221f839802de34c89f5b6454a7e2ac675863ea5 Comparison: 02924fc5b5e19ea84f11dcd5ecbda74796f70efc

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.03	[-6.59, +6.52]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	basic_py_check	% cpu utilization	+1.85	[-0.44, +4.15]
➖	otel_to_otel_logs	ingress throughput	+1.22	[+0.58, +1.86]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.88	[-0.56, +2.32]
➖	file_tree	memory utilization	+0.54	[+0.46, +0.62]
➖	trace_agent_msgpack	ingress throughput	+0.03	[+0.02, +0.04]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.00	[-0.04, +0.03]
➖	file_to_blackhole	% cpu utilization	-0.03	[-6.59, +6.52]
➖	process_agent_standard_check	memory utilization	-0.04	[-0.07, -0.01]
➖	process_agent_real_time_mode	memory utilization	-0.05	[-0.08, -0.01]
➖	process_agent_standard_check_with_stats	memory utilization	-0.08	[-0.11, -0.04]
➖	idle	memory utilization	-0.14	[-0.17, -0.10]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.23	[-0.28, -0.17]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[agent-platform-auto-pr[bot]]

[Fast Unit Tests Report]

On pipeline 31640593 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=31640593 --os-family=ubuntu

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 3829ec33-04f7-4360-8754-ce8e417697ac Baseline: 58b3776f8fdc8673f58679349f561ae454c59a86 Comparison: 8c6ae7a8b6880e47a916a173be8057dc429a4c9d

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.69	[-4.84, +6.22]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	basic_py_check	% cpu utilization	+0.94	[-1.49, +3.37]
➖	file_to_blackhole	% cpu utilization	+0.69	[-4.84, +6.22]
➖	otel_to_otel_logs	ingress throughput	+0.27	[-0.17, +0.71]
➖	idle	memory utilization	+0.07	[+0.04, +0.10]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.06	[-0.03, +0.15]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.06	[-2.78, +2.90]
➖	trace_agent_msgpack	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.03, +0.03]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.20]
➖	process_agent_real_time_mode	memory utilization	-0.01	[-0.05, +0.03]
➖	trace_agent_json	ingress throughput	-0.04	[-0.08, -0.00]
➖	process_agent_standard_check_with_stats	memory utilization	-0.22	[-0.26, -0.18]
➖	process_agent_standard_check	memory utilization	-0.37	[-0.41, -0.32]
➖	file_tree	memory utilization	-0.49	[-0.58, -0.39]
➖	pycheck_1000_100byte_tags	% cpu utilization	-3.02	[-7.85, +1.80]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[clarkb7]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 23m)

Use /merge -c to cancel this operation!