datadog-agent
datadog-agent copied to clipboard
[NPM-3177] clean up logs on conntracker startup
What does this PR do?
Currently if the EBPF conntracker is disabled via config that will log as an error, which is not desirable behavior. This PR cleans up the logic and logs a bit to be more clear about expected and failure cases
Motivation
https://datadoghq.atlassian.net/browse/NPM-3177
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 99d921eb-c3ae-4ca1-86a4-68a2f197e469 Baseline: ae825812058ad88e75ab4b2f3de114248ea25342 Comparison: 53d47aa7e1832b58d0db93bdb54dc4124bd9f2cf
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -0.61 | [-7.13, +5.92] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +3.39 | [+1.17, +5.60] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.11 | [+0.67, +3.56] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.00 | [+0.92, +1.09] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.13 | [+0.08, +0.17] |
➖ | idle | memory utilization | +0.01 | [-0.02, +0.04] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.04, +0.01] |
➖ | trace_agent_json | ingress throughput | -0.04 | [-0.07, -0.00] |
➖ | process_agent_standard_check | memory utilization | -0.04 | [-0.08, -0.01] |
➖ | file_tree | memory utilization | -0.20 | [-0.28, -0.12] |
➖ | process_agent_real_time_mode | memory utilization | -0.20 | [-0.24, -0.16] |
➖ | file_to_blackhole | % cpu utilization | -0.61 | [-7.13, +5.92] |
➖ | otel_to_otel_logs | ingress throughput | -1.88 | [-2.49, -1.27] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is going to start soon! (estimated merge in less than 27m)
Use /merge -c
to cancel this operation!