datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Read and propagate helm config for security products

Open robertpi opened this issue 1 year ago • 3 comments
trafficstars

What does this PR do?

This PR is indent to allow ASM, IAST and SCA to be enabled (or disabled) by Helm Charts config on the controller pod. The cluster-agent, running on the controller pod, will read some environment variables and use this to mutate the configuration of other pod to set the environment variables that will activate products within the client libraries.

Motivation

This will make it easier for k8s clients (at least those using Helm Charts) to activate our products. Simplified installation is a common request.

Additional Notes

The PR will is designed to work with this PR: https://github.com/DataDog/helm-charts/pull/1337

Each product will have env var with the following format:

  • DD_product_ENABLED_PROPAGATE - overall enable disable switch
  • DD_product_ENABLED_PROPAGATE_NAMESPACES - filter for namespaces where the products should enabled
  • DD_product_DISABLED_PROPAGATE_NAMESPACES - filter for namespaces where the products shouldn't enabled

It will result in the a variable with the following format be propagated to all pods (or those conforming to the filters):

DD_product_ENABLED

Possible Drawbacks / Trade-offs

Adds more complexity to our config handling.

Describe how to test/QA your changes

  • Unit tests have been added
  • Manual end to end testing has been preformed

robertpi avatar Mar 08 '24 12:03 robertpi

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Mar 08 '24 12:03 bits-bot

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 238dac63-6905-4342-84d5-7b4298dfac47 Baseline: c7b1b2024b8fa779dcb8d21d5d227210a8af95cb Comparison: 22443796cab7f2dfa4db5bb612e7e92805c9031b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.66 [-7.18, +5.87]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +2.01 [+0.57, +3.46]
file_tree memory utilization +1.75 [+1.65, +1.84]
process_agent_real_time_mode memory utilization +0.69 [+0.64, +0.73]
process_agent_standard_check memory utilization +0.60 [+0.56, +0.64]
process_agent_standard_check_with_stats memory utilization +0.36 [+0.32, +0.40]
idle memory utilization +0.04 [-0.00, +0.09]
trace_agent_json ingress throughput +0.04 [+0.01, +0.07]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.01 [-0.02, -0.00]
tcp_syslog_to_blackhole ingress throughput -0.42 [-0.47, -0.36]
file_to_blackhole % cpu utilization -0.66 [-7.18, +5.87]
otel_to_otel_logs ingress throughput -0.67 [-1.33, -0.01]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 08 '24 14:03 pr-commenter[bot]

closing in favour of the simpler https://github.com/DataDog/datadog-agent/pull/23618

robertpi avatar Mar 11 '24 12:03 robertpi