datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Track blocked channels

Open StephenWakely opened this issue 1 year ago • 1 comments
trafficstars

Very WIP.

This adds the ability to time how long a message is on a number of channels and records this in a histogram.

StephenWakely avatar Mar 08 '24 10:03 StephenWakely

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Mar 08 '24 10:03 bits-bot

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=31346137 --os-family=ubuntu

pr-commenter[bot] avatar Apr 03 '24 13:04 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 32f485ab-ddb2-44b9-8a5a-532908766fdc Baseline: 15ed45e776b2e2d3d216f1b9831eef34e649317c Comparison: 3c512f11e30016df5073fc1460967975b59d9662

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput -29.00 [-29.09, -28.92]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +16.17 [+10.05, +22.28]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +16.17 [+10.05, +22.28]
idle memory utilization +0.78 [+0.74, +0.83]
uds_dogstatsd_to_api_cpu % cpu utilization +0.61 [-2.43, +3.64]
basic_py_check % cpu utilization +0.45 [-2.15, +3.04]
otel_to_otel_logs ingress throughput +0.12 [-0.33, +0.56]
process_agent_standard_check_with_stats memory utilization +0.09 [+0.05, +0.14]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.03]
trace_agent_json ingress throughput +0.01 [-0.00, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.05]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
process_agent_real_time_mode memory utilization -0.26 [-0.31, -0.22]
file_tree memory utilization -0.28 [-0.41, -0.16]
process_agent_standard_check memory utilization -0.39 [-0.44, -0.33]
pycheck_1000_100byte_tags % cpu utilization -2.09 [-6.94, +2.76]
tcp_syslog_to_blackhole ingress throughput -29.00 [-29.09, -28.92]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Apr 03 '24 13:04 pr-commenter[bot]