Refacto logger's code

[louis-cqrl]

trafficstars

What does this PR do?

This PR remove duplicated code and align lock logic to every function, moreover function that work on same part of the logger are group together to make the research inside this file easier

Motivation

Due to last changes in the logger to avoid data race, the code was a bit messy, this PR is here to make the code easier to read and understand.

Additional Notes

Possible Drawbacks / Trade-offs

Due to the add of sub-function, according to the number of call on this function the execution may be slower

Describe how to test/QA your changes

• See if the number of lock is more or less the same as before
• See if the logs are the same (ie. it don't goes in a if condition that it shouldn't)

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 24ddee61-c993-4448-9d4c-1e856f055d1e Baseline: a7631159f5a4e0ac20dd4124aab7b435fd981a11 Comparison: 109e40480547aa74ce228aa0c29b75bc216d0863

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.76	[-5.81, +7.32]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.76	[-5.81, +7.32]
➖	basic_py_check	% cpu utilization	+0.55	[-1.77, +2.86]
➖	idle	memory utilization	+0.48	[+0.43, +0.52]
➖	otel_to_otel_logs	ingress throughput	+0.21	[-0.43, +0.85]
➖	process_agent_standard_check	memory utilization	+0.21	[+0.17, +0.24]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.10	[-1.36, +1.56]
➖	trace_agent_json	ingress throughput	+0.00	[-0.03, +0.04]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	process_agent_standard_check_with_stats	memory utilization	-0.00	[-0.03, +0.02]
➖	process_agent_real_time_mode	memory utilization	-0.01	[-0.05, +0.03]
➖	trace_agent_msgpack	ingress throughput	-0.01	[-0.02, +0.00]
➖	file_tree	memory utilization	-0.48	[-0.56, -0.40]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.54	[-0.59, -0.49]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".