datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Removes custom block sizes from SMP experiments

Open scottopell opened this issue 1 year ago • 1 comments
trafficstars

What does this PR do?

Removes custom block sizes from all SMP experiments.

Motivation

Custom block sizes are difficult to reason about and get right. The default values are better in all tested cases.

Additional Notes

I have manually validated each experiment performs the same or better in terms of "amount of data generated".

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

scottopell avatar Mar 07 '24 22:03 scottopell

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 939b500e-854c-4296-b5b4-7e4441d08fea Baseline: c221f839802de34c89f5b6454a7e2ac675863ea5 Comparison: ce9f1184ec9453e6e21a675b8e2984641a6b8fec

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.46 [-6.11, +7.03]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.78 [-2.34, +3.91]
file_to_blackhole % cpu utilization +0.46 [-6.11, +7.03]
process_agent_standard_check memory utilization +0.43 [+0.39, +0.48]
process_agent_real_time_mode memory utilization +0.38 [+0.33, +0.43]
file_tree memory utilization +0.19 [+0.11, +0.27]
otel_to_otel_logs ingress throughput +0.09 [-0.54, +0.71]
basic_py_check % cpu utilization +0.07 [-2.12, +2.25]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.05, +0.05]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.06, +0.06]
idle memory utilization -0.03 [-0.06, +0.01]
trace_agent_json ingress throughput -0.04 [-0.08, -0.00]
trace_agent_msgpack ingress throughput -0.05 [-0.06, -0.03]
tcp_syslog_to_blackhole ingress throughput -0.18 [-0.26, -0.10]
process_agent_standard_check_with_stats memory utilization -0.72 [-0.75, -0.69]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 08 '24 00:03 pr-commenter[bot]

/merge

scottopell avatar Mar 11 '24 20:03 scottopell

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 11 '24 20:03 dd-devflow[bot]