datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-1279] Update Go version to 1.21.8

Open pgimalac opened this issue 1 year ago • 2 comments

What does this PR do?

Update the version of Go used to build the agent to 1.21.8.

Motivation

Various CVE fixes https://github.com/golang/go/issues?q=milestone%3AGo1.21.8+label%3ACherryPickApproved

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Done with usual dashboard monitoring.

pgimalac avatar Mar 07 '24 19:03 pgimalac

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: c98c1fac-c3bd-4ede-a758-02d5e3499372 Baseline: 281a0984351b1cbf42d76f6ee1313ae33d6c881d Comparison: cd7ec50389d3432f75040e462705febb150015fd

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.03 [-6.51, +6.57]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +1.74 [+1.63, +1.85]
idle memory utilization +1.03 [+0.97, +1.08]
otel_to_otel_logs ingress throughput +0.68 [+0.04, +1.31]
tcp_syslog_to_blackhole ingress throughput +0.57 [+0.52, +0.62]
uds_dogstatsd_to_api_cpu % cpu utilization +0.21 [-1.20, +1.63]
process_agent_real_time_mode memory utilization +0.18 [+0.14, +0.22]
process_agent_standard_check_with_stats memory utilization +0.14 [+0.10, +0.18]
file_to_blackhole % cpu utilization +0.03 [-6.51, +6.57]
trace_agent_json ingress throughput +0.01 [-0.02, +0.05]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.01 [-0.02, +0.00]
process_agent_standard_check memory utilization -0.78 [-0.82, -0.75]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 07 '24 20:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 33965bf3-a1aa-41b6-925a-d5f665895932 Baseline: 760ecea30cc9902326f029fe7793b4d148f63fec Comparison: 5b435ec0ad9968030dd7f9d5550b3c5359f88dee

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.48 [-7.20, +6.24]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +1.88 [-0.48, +4.25]
process_agent_standard_check memory utilization +0.46 [+0.43, +0.50]
idle memory utilization +0.05 [+0.02, +0.09]
tcp_syslog_to_blackhole ingress throughput +0.05 [-0.06, +0.17]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.00]
trace_agent_json ingress throughput -0.02 [-0.03, -0.00]
process_agent_real_time_mode memory utilization -0.19 [-0.23, -0.15]
uds_dogstatsd_to_api_cpu % cpu utilization -0.29 [-3.10, +2.52]
process_agent_standard_check_with_stats memory utilization -0.30 [-0.34, -0.26]
otel_to_otel_logs ingress throughput -0.33 [-0.76, +0.10]
file_tree memory utilization -0.36 [-0.46, -0.26]
file_to_blackhole % cpu utilization -0.48 [-7.20, +6.24]
pycheck_1000_100byte_tags % cpu utilization -0.95 [-6.13, +4.23]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 19:03 pr-commenter[bot]

/merge

pgimalac avatar Mar 14 '24 12:03 pgimalac

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 14 '24 12:03 dd-devflow[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30089979 --os-family=ubuntu

pr-commenter[bot] avatar Mar 14 '24 13:03 pr-commenter[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is next! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 14 '24 14:03 dd-devflow[bot]