datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Add missing go mod in modules list

Open pgimalac opened this issue 1 year ago • 1 comments

What does this PR do?

Add some missing Go mod in the modules list.

Motivation

Avoid weird states or errors due to missing modules with automations.

Additional Notes

I thought it would be a trivial fix but it ended up requiring some more changes to please the CI.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pgimalac avatar Mar 07 '24 15:03 pgimalac

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: a27eb479-86f8-4705-af43-4079d65e01ba Baseline: 7550117fa81ba6c32ed04d82e1fa3d99f30b79f7 Comparison: b17179866ed86cf1ef504c5605bfba3a3e4e11b0

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.24 [-6.33, +6.81]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +0.73 [+0.68, +0.78]
process_agent_standard_check memory utilization +0.70 [+0.66, +0.74]
file_tree memory utilization +0.54 [+0.42, +0.67]
otel_to_otel_logs ingress throughput +0.27 [-0.34, +0.89]
file_to_blackhole % cpu utilization +0.24 [-6.33, +6.81]
tcp_syslog_to_blackhole ingress throughput +0.07 [+0.01, +0.13]
trace_agent_json ingress throughput +0.00 [-0.03, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.00 [-0.02, +0.01]
process_agent_standard_check_with_stats memory utilization -0.05 [-0.09, -0.01]
uds_dogstatsd_to_api_cpu % cpu utilization -0.25 [-1.69, +1.20]
process_agent_real_time_mode memory utilization -0.37 [-0.42, -0.32]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 07 '24 19:03 pr-commenter[bot]

/merge

pgimalac avatar Mar 11 '24 11:03 pgimalac

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 11 '24 11:03 dd-devflow[bot]