datadog-agent
datadog-agent copied to clipboard
Add e2e tests for check command on linux
What does this PR do?
Add e2e tests for check subcommand. Only for Linux now because of a encoding issue when creating file on Windows.
Motivation
ASCII-1250
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: c5a08fe0-2de7-41e2-80a0-2709b9aaa14d Baseline: 0608f9c3d8a3884ab935e1fd6432b64d400a4a7b Comparison: 5364e1f9619dc298a07d9fe3740c76a08096b775
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.34 | [-6.88, +6.20] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.66 | [-0.80, +2.11] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.52 | [+0.49, +0.56] |
| ➖ | process_agent_standard_check | memory utilization | +0.33 | [+0.28, +0.37] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.28 | [+0.22, +0.34] |
| ➖ | idle | memory utilization | +0.24 | [+0.20, +0.28] |
| ➖ | file_tree | memory utilization | +0.12 | [+0.04, +0.20] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.05 | [-0.59, +0.69] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.01 | [+0.01, +0.02] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_json | ingress throughput | -0.01 | [-0.06, +0.04] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.26 | [-0.30, -0.22] |
| ➖ | file_to_blackhole | % cpu utilization | -0.34 | [-6.88, +6.20] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is going to start soon! (estimated merge in less than 27m)
Use /merge -c to cancel this operation!